[poppler] [PATCH] Preliminary movie support

[Hugo Mercier]

>
> Not commenging in glib code as we have better people to that.
>
> Minor comments:
>  * Use poppler own types in poppler core code (yeah i know it sucks)
>   * Use poppler's Gulong instead of long in poppler core core
>   * Use poppler's gFalse and gTrue in poppler core core
>   * Use GBool on Movie.h
>  * You killed "Sound" from the if on createAnnot, is that a mistake?
>
> Important things:
>  * The Movie ownernship is not clear to me, AnnotMovie creates one but
> never
> deletes it, that makes an instant leak. Same for LinkRendition. I think
> your
> idea is that people needs to call getMovie and then take care of deleting
> themselves. That's unaccetable because not everyone might want to care
> about
> Annots and because if there are two calls to getMovie it creates a "who
> has
> to delete dilemma". Probably the easiest solution is making the getMovie
> functions return a copy of movie the caller has to care to delete.
>
> Critical things:
>  * Movie.h is GPLv3+ which makes it impossible for us to use it, it needs
> to
> be GPLv2+
>
>

Hi,

Here is another patch (against the last git commit) that fixes these issues.
Ownership of members has been clarified.
I only send a patch that adds movie support to the "core" poppler lib. Movie
access in the glib part has still to be rewritten to conform to recent
changes proposed by Iñigo (PopplerAnnotMapping).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freedesktop.org/archives/poppler/attachments/20080301/2fff0394/attachment-0001.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: poppler_core_movie_support3.patch
Type: text/x-patch
Size: 36047 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20080301/2fff0394/attachment-0001.bin