[poppler] glib/poppler-annot.cc glib/poppler-annot.h

[Iñigo Martínez]

I think it's necessary in the sense that if the glib side it's used, it
will break support in the future.

I think it's better to change it until the official release, so any
program using poppler glib bindings since the official release will not
break in the future releases.

That's why I thought it was something to be done before the release.

El vie, 21-03-2008 a las 20:56 +0100, Albert Astals Cid escribió:
> Do you REALLY need this to be changed? 
> 
> As i said on 12th
> 
> ****
> From now on no API nor ABI changes are allowed unless TOTALLY necessary. Only 
> bugfixes until we release and branch 0.8
> ****
> 
> And i'm not really sure this qualifies as TOTALLY necessary.
> 
> Albert
> 
> A Divendres 21 Març 2008, Inigo Martinez va escriure:
> >  glib/poppler-annot.cc |    4 ++--
> >  glib/poppler-annot.h  |    2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > New commits:
> > commit b33bb282e45cf1a083cfbb13603ac465d386c28d
> > Author: Iñigo Martínez <inigomartinez at gmail.com>
> > Date:   Fri Mar 21 13:53:21 2008 +0100
> >
> >     Fixed poppler glib public api.
> >
> >     Signed-off-by: Iñigo Martínez <inigomartinez at gmail.com>
> >
> > diff --git a/glib/poppler-annot.cc b/glib/poppler-annot.cc
> > index da900a3..3dc5c22 100644
> > --- a/glib/poppler-annot.cc
> > +++ b/glib/poppler-annot.cc
> > @@ -534,7 +534,7 @@ poppler_annot_markup_get_external_data
> > (PopplerAnnotMarkup *poppler_annot)
> >
> >  /* PopplerAnnotText */
> >  /**
> > - * poppler_annot_text_is_open:
> > + * poppler_annot_text_get_is_open:
> >   * @poppler_annot: a #PopplerAnnotText
> >   *
> >   * Retrieves the state of @poppler_annot.
> > @@ -543,7 +543,7 @@ poppler_annot_markup_get_external_data
> > (PopplerAnnotMarkup *poppler_annot) *               other case.
> >   **/
> >  gboolean
> > -poppler_annot_text_is_open (PopplerAnnotText *poppler_annot)
> > +poppler_annot_text_get_is_open (PopplerAnnotText *poppler_annot)
> >  {
> >    AnnotText *annot;
> >
> > diff --git a/glib/poppler-annot.h b/glib/poppler-annot.h
> > index 706e3e1..b11ebbd 100644
> > --- a/glib/poppler-annot.h
> > +++ b/glib/poppler-annot.h
> > @@ -161,7 +161,7 @@ PopplerAnnotExternalDataType 
> > poppler_annot_markup_get_external_data           (
> >
> >  /* PopplerAnnotText */
> >  GType                         poppler_annot_text_get_type                 
> >     (void) G_GNUC_CONST; -gboolean                     
> > poppler_annot_text_is_open                       (PopplerAnnotText
> > *poppler_annot); +gboolean                     
> > poppler_annot_text_get_is_open                   (PopplerAnnotText
> > *poppler_annot); PopplerAnnotTextIcon          poppler_annot_text_get_icon 
> >                     (PopplerAnnotText *poppler_annot);
> > PopplerAnnotTextState         poppler_annot_text_get_state                 
> >    (PopplerAnnotText *poppler_annot);
> 
> 
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada
	digitalmente
Url : http://lists.freedesktop.org/archives/poppler/attachments/20080321/302439d9/attachment.pgp