[poppler] [PATCH] Arthur backend fixes; poppler-qt4 direct rendering

Albert Astals Cid aacid at kde.org
Tue Nov 2 16:53:14 PDT 2010


A Dimarts, 2 de novembre de 2010, Matthias Fauconneau va escriure:
> > Yep, the API sucks.
> 
> I ran valgrind again and it was still leaking. It should be tight now.
> It would be great if more code could be shared with Splash, since the
> leaks I've found where already fixed in the original splash backend.

Yep, actually it would be good if Qt support for loading and used fonts did 
not suck and we were forced to use Splash font part in the Arthur renderer.

> 
> > Are you sure you need the
> > for (x = 0; x < width; x++) { *dest = *dest | 0xff000000; dest++; }
> > ?
> 
> It works without when using direct rendering (both raster and opengl)
> but not with renderToImage.

Ok, weird thing.

Anyhow the patch looks ok to me, Pino what do you say?

Albert


More information about the poppler mailing list