[poppler] Patches for SplashBitmap/PNGWriter

[Albert Astals Cid]

A Dijous, 19 d'agost de 2010, Stefan Thomas va escriure:
> > Moving the `delete[] row;` should avoid requiring two identical lines:
> >        delete[] row;
> > 
> > +      if (!writer->close()) {
> > +        return splashErrGeneric;
> > +      }
> 
> Yes, but libjpeg keeps a reference to row and may access it during
> jpeg_finish_compress(). So deleting row before writer->close() is a Bad
> Idea.

I still can't reproduce any problem with the current code, do you have any pdf 
you can share where i can see the current pdftoppm in trunk master generates a 
wrong jpg file?

Albert

> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler