[poppler] Poppler reg tests

Albert Astals Cid aacid at kde.org
Tue Sep 13 06:27:34 PDT 2011


A Dimarts, 13 de setembre de 2011, Carlos Garcia Campos vàreu escriure:
> Excerpts from Albert Astals Cid's message of mar sep 13 14:13:37 +0200 2011:
> > A Dimarts, 13 de setembre de 2011, Carlos Garcia Campos vàreu escriure:
> > > Excerpts from Albert Astals Cid's message of mar sep 13 12:27:27 +0200 
2011:
> > > > A Dilluns, 12 de setembre de 2011, Carlos Garcia Campos vàreu 
escriure:
> > > > > Hi all,
> > > > 
> > > > Hi
> > > > 
> > > > > as you all probably know, our current regression test suite
> > > > > are some custom shell scripts and a lot of pdf files that
> > > > > Albert has collected
> > > > > for some years. During the last few days I have been working
> > > > > on
> > > > > improving the regression test, converting Albert's scripts
> > > > > into a
> > > > > small python program to allow everybody to run their own
> > > > > tests. We
> > > > > are
> > > > > not going to upload pdfs to the repo, so we still depend on
> > > > > Albert
> > > > > to make sure a change doesn't actually introduce
> > > > > regressions.
> > > > > 
> > > > > SNIP
> > > > > 
> > > > > There are still things to do, like adding an option to
> > > > > provide
> > > > > documents to skip,
> > > > 
> > > > Yeah, the documents to skip is important, i have a few files
> > > > here that cause infinite loops because of errors in things we
> > > > do not control (like openjpeg) and i need to be able of
> > > > ignoring those.
> > > 
> > > For now, as a workaround you could rename the files to skip as
> > > something like pdf_document_i_want_to_skip.pdf.skip, since only
> > > .pdf files are used.
> > 
> > Poor man solution, but yeah, would work
> 
> It's a workaround not a real fix, I'll implement proper skipped list soon.

Great :-)

> 
> > > > It would be good to have some sense of how the test is
> > > > progressing, the problem at the moment is that files are tested
> > > > in "random" order, so can not use the current file to know how
> > > > much is left. It would be good either to sort the files or to
> > > > get a "1 of 1000" text to know how much is left
> > > 
> > > Yes, it happened to me yesterday too, it would take a bit longer,
> > > but
> > > I guess it's better to get information about the tests first, sort
> > > it,
> > > and then iterate it to create the refs and run the tests.
> > 
> > Yeah, time "lost" time should be really small compared to real running
> > time
> Sure, I'll do it.

Great :-)

> > 
> > I'm a bit hesitant to commiting this before we branch for 0.18. If you
> > want to commit it now i can create the branch for 0.18.x today so you
> > can commit it to master.
> 
> Note that this is intended to be used from a git clone, it's not
> thought to be included in tarballs, so it shouldn't affect any
> release.

Sure, but it will still be part of the tag. Nothing major I know :D So feel 
free to commit it.

Albert


More information about the poppler mailing list