[poppler] [PATCH] per-collection fallback for missing CID-keyed fonts on Win32

Albert Astals Cid aacid at kde.org
Fri Apr 6 06:14:47 PDT 2012


El Dilluns, 2 d'abril de 2012, a les 18:50:16, mpsuzuki at hiroshima-u.ac.jp va 
escriure:
> Dear Thomas,
> 
> On Mon, 02 Apr 2012 11:21:51 +0200
> 
> Thomas Freitag <Thomas.Freitag at kabelmail.de> wrote:
> >Am 01.04.2012 19:59, schrieb suzuki toshiya:
> >> Dear Thomas,
> >> 
> >> I uploaded a preliminary patch for this issue to
> >> 
> >> 	https://bugs.freedesktop.org/show_bug.cgi?id=48046
> >> 
> >> The patch is to git head, a5f4936dfb3e60ca37f932cc066aa10765f3cbc9
> >> Please check.
> >
> >Tested, it is okay, but You should remove the fprintf's in replaceSuffix
> >and makeWindowsFont or use the directive _DEBUG.
> 
> Thanks. Of course, the debug messages should be removed.
> 
> >> Checking the font related members of GlobalParams class, I think
> >> current code doing the substitution with external fonts is confused,
> >> and FontInfo class is infected (e.g. the result of "pdffonts -subst"
> >> will be different from how SplashOutput substitutes the non-embedded
> >> fonts). Some overhaul is needed, and I'm willing to do it after 0.20
> >
> >Not the fonts which are replaced by findSystemFontFile. Here hopefully
> >pdffonts -subst will show the correct names. The problems are the
> >base14-names from the GfxFont::base14FontMap. Here the behaviour
> >completely changed between before and after the merge. Before the merge
> >the member "name" from the object Font is already "mangled" by the
> >substituted name, after the merge it is still the name from the PDF and
> >the substituted name is found in
> >"((Gfx8BitFont*)this)->base14->base14Name".
> Again thanks, I have not checked the history of pdffonts.
> It sounds that the behaviour before the merge is better
> than the current behaviour.
> 
> >But of course, a correction is always welcome....
> 
> I think, pdffonts should notice how the fonts are fallbacked
> in the rasterization (or the conversion to vector output
> device), primarily. 

Are you speaking of pdffonts -subst here? Seems to work fine for me. Or are 
you saying it doesn't work in Windows?

> As the extra features, the indication of
> the last rule choosing the final result would be helpful,
> when poppler have external configuration file to control the
> font substition (it's since 0.20!).

External configuration file to control font substitution is something we do 
*not* want.

Albert

> 
> Regards,
> mpsuzuki


More information about the poppler mailing list