[poppler] utils/Makefile.am should copy libcms-related flags for pdftocairo?

mpsuzuki at hiroshima-u.ac.jp mpsuzuki at hiroshima-u.ac.jp
Wed Jan 11 09:53:17 PST 2012


Hi,

Current cmake file (utils/CMakeLists.txt) adds libcms
to library list to build pdftocairo, like,

  add_executable(pdftocairo ${pdftocairo_SOURCES})
  target_link_libraries(pdftocairo ${CAIRO_LIBRARIES} ${FREETYPE_LIBRARIES} ${common_libs})
  if(LCMS_FOUND)
    target_link_libraries(pdftocairo ${LCMS_LIBRARIES})
  endif(LCMS_FOUND)

But utils/Makefile.am does not do such. If it's not my
misunderstanding, please consider to add LCMS_{CFLAGS,LIBS}
to PDFTOCAIRO_{CFLAGS,LIBS} when USE_CMS is defined.
Patch is following.

Regards,
mpsuzuki

diff --git a/utils/Makefile.am b/utils/Makefile.am
index 951abdb..762598c 100644
--- a/utils/Makefile.am
+++ b/utils/Makefile.am
@@ -30,6 +30,11 @@ pdftocairo_SOURCES =				\
 	pdftocairo.cc				\
 	$(common)
 
+if USE_CMS
+PDFTOCAIRO_CFLAGS += $(LCMS_CFLAGS)
+PDFTOCAIRO_LIBS += $(LCMS_LIBS)
+endif
+
 pdftocairo_LDADD =				\
 	$(top_builddir)/poppler/libpoppler-cairo.la \
 	$(LDADD) $(PDFTOCAIRO_LIBS)


More information about the poppler mailing list