[poppler] RFC: Expose whole-words search option in Qt frontends

[Adam Reichold]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hello,

Am 10.01.2015 um 23:45 schrieb Albert Astals Cid:
> Maybe you can add some tests to check_search.cpp?

Attached patch with a test case for the four flag combinations added
to the Qt4 and Qt5 versions of "check_search.cpp".

Of course, this very much highlights the ugliness of shoe horning the
flags into the existing enumeration. But I don't think that making
"Poppler::Page::search" take an "int" instead of "SearchMode" would be
ABI compatible strictly speaking, since now the compiler is free to
choose the underlying type for the enumeration.

Best regards, Adam.

> Cheers, Albert
> 
> El Dissabte, 10 de gener de 2015, a les 23:26:01, Adam Reichold va
> escriure:
>> Hello again,
>> 
>> Am 10.01.2015 um 22:25 schrieb Albert Astals Cid:
>>> El Dissabte, 10 de gener de 2015, a les 17:51:48, Adam Reichold
>>> va
>>> 
>>> escriure:
>>>> Hello,
>>>> 
>>>> Attach is a patch that would expose Poppler's whole-words
>>>> search option within the Qt frontends.
>>>> 
>>>> While the implementation seems straight forward so far, I
>>>> would like to request comments whether extending the
>>>> "SearchMode" enumeration to flag definition is considered
>>>> harmless. The proper way to do it seems to be the
>>>> introduction of "QFlags<SearchMode>" which would however
>>>> break compatibility and hence imply the need to have an
>>>> additional overloads using a separate flag (and enumeration?)
>>>> definition.
>>> 
>>> Looks good to me. The qt5/ side would need the documentation
>>> update too, no?
>> 
>> patch with fixed Qt5 documentation and "\since" commands
>> attached.
>> 
>> Best regards, Adam.
>> 
>>> Cheers, Albert
>>> 
>>>> Best regards, Adam.
>>> 
>>> _______________________________________________ poppler
>>> mailing list poppler at lists.freedesktop.org 
>>> http://lists.freedesktop.org/mailman/listinfo/poppler
> 
> 
> _______________________________________________ poppler mailing
> list poppler at lists.freedesktop.org 
> http://lists.freedesktop.org/mailman/listinfo/poppler
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJUsbe8AAoJEPSSjE3STU34+qYIAMeoWptZ/vpQ+/q0bm7wmyvz
eOAULufrXlaH5OkNRsTRF/q6273um9zqPELtX9BFP5HnxXuufQnaYsUlwwhlUqms
LGEJ+g363hxFOj9xq0IhfFfoFZkeoc233tX1aFtU6bWlTQ8llgZi+fT7dOhZFZRN
vjjhZs4kTAR1p9vvXYvy08uyU1tsVLzBPl9m+eZ3G2555CRUtzBtn7zwaiI88yA0
4pWjqE7Mn5LqU30hMPQiuda605CPd8hqZrQeKBCZpBUp2gzUtUj4vgSUGWHo32bV
nO9DFOuduhwO7Je4XLLKI7rFnpj61M4oipzu/OV57U3JbwoMNmCL9KkXJ7I97MI=
=a0vd
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: whole-words-only.patch
Type: text/x-patch
Size: 21629 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20150111/b792d397/attachment-0001.bin>