<html>
<head>
<style>
P
{
margin:0px;
padding:0px
}
body
{
FONT-SIZE: 10pt;
FONT-FAMILY:Tahoma
}
</style>
</head>
<body>Krzysztof Kowalczyk wrote:<br>&gt; Is&nbsp;there&nbsp;interest&nbsp;among&nbsp;poppler&nbsp;developers&nbsp;to&nbsp;maintain&nbsp;win32&nbsp;portability?<br><br>I am interested, having ported Poppler over to VC/Win32 myself.<br><br>&gt; I&nbsp;just&nbsp;started&nbsp;working&nbsp;on&nbsp;a&nbsp;PDF&nbsp;viewer&nbsp;for&nbsp;Windows<br>&gt; (http://blog.kowalczyk.info/software/sumatrapdf).&nbsp;Initially&nbsp;I&nbsp;used<br>&gt; xpdf&nbsp;but&nbsp;just&nbsp;ported&nbsp;it&nbsp;to&nbsp;poppler&nbsp;and&nbsp;would&nbsp;much&nbsp;rather&nbsp;stick&nbsp;with<br>&gt; poppler&nbsp;since&nbsp;it&nbsp;has&nbsp;more&nbsp;open&nbsp;and&nbsp;more&nbsp;active&nbsp;development&nbsp;so&nbsp;that&nbsp;I<br>&gt; can&nbsp;benefit&nbsp;from&nbsp;fixes&nbsp;made&nbsp;to&nbsp;poppler&nbsp;and&nbsp;others&nbsp;can&nbsp;benefit&nbsp;from<br>&gt; fixes&nbsp;that&nbsp;I&nbsp;make.<br><br>I have made similar fixes while looking at Poppler.<br><br>NOTE: you need to be careful when removing unused variables that<br>they are not actually being used inside a #ifdef...#endif block!<br><br>&gt; I&nbsp;would&nbsp;be&nbsp;happy&nbsp;to&nbsp;maintain&nbsp;win32&nbsp;portability.&nbsp;I've&nbsp;opened&nbsp;a&nbsp;bug&nbsp;and<br>&gt; attached&nbsp;a&nbsp;patch&nbsp;to&nbsp;bring&nbsp;the&nbsp;latest&nbsp;cvs&nbsp;version&nbsp;of&nbsp;poppler&nbsp;to&nbsp;compile<br>&gt; on&nbsp;Windows&nbsp;under&nbsp;Visual&nbsp;Studio&nbsp;2005<br>&gt; (https://bugs.freedesktop.org/show_bug.cgi?id=7107).<br><br>I have updated that to include my alternative patch.<br><br>&gt; Is&nbsp;that&nbsp;the&nbsp;best&nbsp;way&nbsp;to&nbsp;submit&nbsp;patches&nbsp;in&nbsp;order&nbsp;to&nbsp;get&nbsp;them&nbsp;into&nbsp;main<br>&gt; tree&nbsp;or&nbsp;should&nbsp;I&nbsp;use&nbsp;some&nbsp;other&nbsp;way&nbsp;(e.g.&nbsp;send&nbsp;the&nbsp;patches&nbsp;to&nbsp;mailing<br>&gt; list)?<br><br>I assume that this would be the best approach, then they don't get lost<br>like my VC patch did!<br><br>- Reece<br><br /><hr />Express yourself instantly with MSN Messenger! <a href='http://clk.atdmt.com/AVE/go/onm00200471ave/direct/01/' target='_new'>MSN Messenger</a></body>
</html>