<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hello Leonard!<br>
<br>
Just to clearify:<br>
<br>
if out->drawImageMask(state, ref, str, width, height, invert,
inlineImg); is not done, there is no mask (i.e. clipping path) which
can be filled. Therefore Carlos is true: the curly brackets must be
there!<br>
<br>
Best regards,<br>
Thomas<br>
<br>
Leonard Rosenthol schrieb:
<blockquote
cite="mid:D23D6B9E57D654429A9AB6918CACEAA97C3E8527CA@NAMBX02.corp.adobe.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; ">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="Section1">
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);">Depends
on what “contentIsHidden()” is testing. <o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);">If
it is testing something like clipping bounds – then yes,
there is no reason to render the content if it’s “offscreen”.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);">HOWEVER,
if that is a test of optional content, then you STILL
need to “pretend” to render the content – but not actually put
any bits down. This is stipulate in the PDF Ref/ISO 32K because it
ensures
that any states (including text position) are maintained even if
something is
not currently visible.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);">Leonard<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);"><o:p> </o:p></span></p>
<div>
<div
style="border-style: solid none none; border-color: rgb(181, 196, 223) -moz-use-text-color -moz-use-text-color; border-width: 1pt medium medium; padding: 3pt 0in 0in;">
<p class="MsoNormal"><b><span
style="font-size: 10pt; font-family: "Tahoma","sans-serif"; color: windowtext;">From:</span></b><span
style="font-size: 10pt; font-family: "Tahoma","sans-serif"; color: windowtext;">
<a class="moz-txt-link-abbreviated" href="mailto:poppler-bounces@lists.freedesktop.org">poppler-bounces@lists.freedesktop.org</a>
[<a class="moz-txt-link-freetext" href="mailto:poppler-bounces@lists.freedesktop.org">mailto:poppler-bounces@lists.freedesktop.org</a>] <b>On Behalf Of </b>Thomas
Freitag<br>
<b>Sent:</b> Thursday, June 04, 2009 2:33 AM<br>
<b>To:</b> Albert Astals Cid<br>
<b>Cc:</b> <a class="moz-txt-link-abbreviated" href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a><br>
<b>Subject:</b> Re: [poppler] 4 commits - CMakeLists.txt
poppler/Gfx.cc
poppler/Gfx.h poppler/GfxState.cc poppler/GfxState_helpers.h
poppler/Makefile.am poppler/OutputDev.h poppler/PSOutputDev.cc
poppler/PSOutputDev.h poppler/SplashOutputDev.cc
poppler/SplashOutputDev...<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hello Albert!<br>
<br>
Sorry, Carlos is true: Also the filling should (and MUST) only be done
if
content is NOT hidden, therefore the curly brackets must be inserted.<br>
<br>
Best regards,<br>
Thomas<br>
<br>
Albert Astals Cid schrieb: <o:p></o:p></p>
<pre>A Dimecres, 3 de juny de 2009, Carlos Garcia Campos va escriure:<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<blockquote style="margin-top: 5pt; margin-bottom: 5pt;">
<pre>El mar, 02-06-2009 a las 14:02 -0700, Albert Astals Cid escribió:<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<blockquote style="margin-top: 5pt; margin-bottom: 5pt;">
<pre>@@ -3695,6 +3780,12 @@ void Gfx::doImage(Object *ref, Stream *str,<o:p></o:p></pre>
<pre>GBool inlineImg) {<o:p></o:p></pre>
<pre> // draw it<o:p></o:p></pre>
<pre> if (!contentIsHidden())<o:p></o:p></pre>
<pre> out->drawImageMask(state, ref, str, width, height, invert,<o:p></o:p></pre>
<pre>inlineImg);<o:p></o:p></pre>
<pre>+ if (out->fillMaskCSPattern(state)) {<o:p></o:p></pre>
<pre>+ maskHaveCSPattern = gTrue;<o:p></o:p></pre>
<pre>+ doPatternFill(gTrue);<o:p></o:p></pre>
<pre>+ out->endMaskClip(state);<o:p></o:p></pre>
<pre>+ maskHaveCSPattern = gFalse;<o:p></o:p></pre>
<pre>+ }<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre> } else {<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
</blockquote>
<pre>I think {} are missing there, I guess it should be:<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>if (!contentIsHidden()) {<o:p></o:p></pre>
<pre> out->drawImageMask(state, ref, str, width, height, invert, inlineImg);<o:p></o:p></pre>
<pre> if (out->fillMaskCSPattern(state)) {<o:p></o:p></pre>
<pre> [....]<o:p></o:p></pre>
<pre> }<o:p></o:p></pre>
<pre>}<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>or am I wrong?<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
</blockquote>
<pre><o:p> </o:p></pre>
<pre>Good question, Thomas?<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Albert<o:p></o:p></pre>
</div>
</blockquote>
</body>
</html>