Hi, <div style="margin-left: 40px;">By considering the suggestions from Carlos & Pino Toscano, I made some changes to the previous patch. </div> As Carlos mentioned, I added PDFDoc:getID() in the core and from the glib bindings took the structure for PopplerDocumentId and returning it. In addition to that I added two new properties in the PopplerDocument namely, "permanent-id" , "update-id". As Carlos mentioned PDFDoc::saveAs() will not generate ID unless we modify and save the file. If we don't modify and save it, it is nothing but save a copy.So, I added PDFDoc::setID() in the core. Please find two attachments with this mail containing the above said changes. <div class="gmail_quote">On Sat, Jun 12, 2010 at 12:30 AM, <<a href="mailto:poppler-request@lists.freedesktop.org">poppler-request@lists.freedesktop.org</a>> wrote: <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Send poppler mailing list submissions to <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a> To subscribe or unsubscribe via the World Wide Web, visit <a href="http://lists.freedesktop.org/mailman/listinfo/poppler" target="_blank">http://lists.freedesktop.org/mailman/listinfo/poppler</a> or, via email, send a message with subject or body 'help' to <a href="mailto:poppler-request@lists.freedesktop.org">poppler-request@lists.freedesktop.org</a> You can reach the person managing the list at <a href="mailto:poppler-owner@lists.freedesktop.org">poppler-owner@lists.freedesktop.org</a> When replying, please edit your Subject line so it is more specific than "Re: Contents of poppler digest..." Today's Topics: 1. Re: Patch to Get/Set PDF ID in the trailer dictionary, get page labels . (Carlos Garcia Campos) ---------------------------------------------------------------------- Message: 1 Date: Fri, 11 Jun 2010 12:31:47 +0200 From: Carlos Garcia Campos <<a href="mailto:carlosgc@gnome.org">carlosgc@gnome.org</a>> Subject: Re: [poppler] Patch to Get/Set PDF ID in the trailer dictionary, get page labels . To: srinivas adicherla <<a href="mailto:srinivas.adicherla@gmail.com">srinivas.adicherla@gmail.com</a>> Cc: poppler <<a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a>> Message-ID: <1276251137-sup-4795@charmaleon> Content-Type: text/plain; charset="utf8" Excerpts from srinivas adicherla's message of jue jun 10 12:13:25 +0200 2010: > Hi, Hi srinivas, > This Patch does the following: Thanks for the patch, I some comments: > 1) gets and set the pdf IDs in the trailer dictionary. The code to get ID could be moved to the core, so that it can be used by other frontends, someting like PDFDoc::getID(). In the glib frontend, instead of returning an array we could use a struct so that we can also give names to the fields, since the first id is the permanent id and the second one is the id that changes when the document is updated. Something like typedef struct _PopplerDocumentId { gchar permanent_id[32]; gchar update_id[32]; } PopplerDocumentId; The method generate_and_set_id() shouldn't be necessary since PDFDoc::saveAS() already generates a new id. > 2) get all page labels & get page labels by index. We already have labels in the glib frontend, it's property of PopplerPage that can be obtained with g_object_get (page, "label", &label, NULL); I don't think we need that API in PopplerDocument, but we should probably expose it in the PopplerPage API to make it easier to find. > Kindly let me know if You commit this patch. > > > Thanks > A Srinivas -- Carlos Garcia Campos PGP key: <a href="http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462" target="_blank">http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462</a> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: not available URL: <<a href="http://lists.freedesktop.org/archives/poppler/attachments/20100611/3ab6035b/attachment-0001.pgp" target="_blank">http://lists.freedesktop.org/archives/poppler/attachments/20100611/3ab6035b/attachment-0001.pgp</a>> ------------------------------ _______________________________________________ poppler mailing list <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/poppler" target="_blank">http://lists.freedesktop.org/mailman/listinfo/poppler</a> End of poppler Digest, Vol 64, Issue 9 ************************************** </blockquote></div>