Hi, Thank you all once again for giving me valuable suggestions. I modified the previous patch. I attached the new patch with this mail. Iam curiously waiting for to commit my patch. Please let me know when you commit this patch. Thanks -- A Srinivas <div class="gmail_quote">On Wed, Jun 23, 2010 at 12:30 AM, <<a href="mailto:poppler-request@lists.freedesktop.org">poppler-request@lists.freedesktop.org</a>> wrote: <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Send poppler mailing list submissions to <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a> To subscribe or unsubscribe via the World Wide Web, visit <a href="http://lists.freedesktop.org/mailman/listinfo/poppler" target="_blank">http://lists.freedesktop.org/mailman/listinfo/poppler</a> or, via email, send a message with subject or body 'help' to <a href="mailto:poppler-request@lists.freedesktop.org">poppler-request@lists.freedesktop.org</a> You can reach the person managing the list at <a href="mailto:poppler-owner@lists.freedesktop.org">poppler-owner@lists.freedesktop.org</a> When replying, please edit your Subject line so it is more specific than "Re: Contents of poppler digest..." Today's Topics: 1. poppler/GfxState.cc (Albert Astals Cid) 2. Branch 'poppler-0.14' - poppler/GfxState.cc (Albert Astals Cid) 3. Re: Patch go Get PDF ID (Albert Astals Cid) ---------------------------------------------------------------------- Message: 1 Date: Mon, 21 Jun 2010 12:38:22 -0700 (PDT) From: <a href="mailto:aacid@kemper.freedesktop.org">aacid@kemper.freedesktop.org</a> (Albert Astals Cid) Subject: [poppler] poppler/GfxState.cc To: <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a> Message-ID: <<a href="mailto:20100621193823.4F08210057@kemper.freedesktop.org">20100621193823.4F08210057@kemper.freedesktop.org</a>> poppler/GfxState.cc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 38e5d28a184d0ca8df71a7ea910ce85d7a225e4e Author: Albert Astals Cid <<a href="mailto:aacid@kde.org">aacid@kde.org</a>> Date: Mon Jun 21 20:38:00 2010 +0100 more pow 0.5 -> sqrt diff --git a/poppler/GfxState.cc b/poppler/GfxState.cc index 7140efc..fe3ee77 100644 --- a/poppler/GfxState.cc +++ b/poppler/GfxState.cc @@ -672,9 +672,9 @@ void GfxCalGrayColorSpace::getRGB(GfxColor *color, GfxRGB *rgb) { r = xyzrgb[0][0] * X + xyzrgb[0][1] * Y + xyzrgb[0][2] * Z; g = xyzrgb[1][0] * X + xyzrgb[1][1] * Y + xyzrgb[1][2] * Z; b = xyzrgb[2][0] * X + xyzrgb[2][1] * Y + xyzrgb[2][2] * Z; - rgb->r = dblToCol(pow(clip01(r * kr), 0.5)); - rgb->g = dblToCol(pow(clip01(g * kg), 0.5)); - rgb->b = dblToCol(pow(clip01(b * kb), 0.5)); + rgb->r = dblToCol(sqrt(clip01(r * kr))); + rgb->g = dblToCol(sqrt(clip01(g * kg))); + rgb->b = dblToCol(sqrt(clip01(b * kb))); rgb->r = rgb->g = rgb->b = clip01(color->c[0]); } @@ -1246,9 +1246,9 @@ void GfxLabColorSpace::getRGB(GfxColor *color, GfxRGB *rgb) { r = xyzrgb[0][0] * X + xyzrgb[0][1] * Y + xyzrgb[0][2] * Z; g = xyzrgb[1][0] * X + xyzrgb[1][1] * Y + xyzrgb[1][2] * Z; b = xyzrgb[2][0] * X + xyzrgb[2][1] * Y + xyzrgb[2][2] * Z; - rgb->r = dblToCol(pow(clip01(r * kr), 0.5)); - rgb->g = dblToCol(pow(clip01(g * kg), 0.5)); - rgb->b = dblToCol(pow(clip01(b * kb), 0.5)); + rgb->r = dblToCol(sqrt(clip01(r * kr))); + rgb->g = dblToCol(sqrt(clip01(g * kg))); + rgb->b = dblToCol(sqrt(clip01(b * kb))); } void GfxLabColorSpace::getCMYK(GfxColor *color, GfxCMYK *cmyk) { ------------------------------ Message: 2 Date: Mon, 21 Jun 2010 12:38:48 -0700 (PDT) From: <a href="mailto:aacid@kemper.freedesktop.org">aacid@kemper.freedesktop.org</a> (Albert Astals Cid) Subject: [poppler] Branch 'poppler-0.14' - poppler/GfxState.cc To: <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a> Message-ID: <<a href="mailto:20100621193848.8814910057@kemper.freedesktop.org">20100621193848.8814910057@kemper.freedesktop.org</a>> poppler/GfxState.cc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 714db8900b2f72bd63811a16bfb81beb23397bba Author: Albert Astals Cid <<a href="mailto:aacid@kde.org">aacid@kde.org</a>> Date: Mon Jun 21 20:38:00 2010 +0100 more pow 0.5 -> sqrt diff --git a/poppler/GfxState.cc b/poppler/GfxState.cc index 4f83e61..b59a478 100644 --- a/poppler/GfxState.cc +++ b/poppler/GfxState.cc @@ -672,9 +672,9 @@ void GfxCalGrayColorSpace::getRGB(GfxColor *color, GfxRGB *rgb) { r = xyzrgb[0][0] * X + xyzrgb[0][1] * Y + xyzrgb[0][2] * Z; g = xyzrgb[1][0] * X + xyzrgb[1][1] * Y + xyzrgb[1][2] * Z; b = xyzrgb[2][0] * X + xyzrgb[2][1] * Y + xyzrgb[2][2] * Z; - rgb->r = dblToCol(pow(clip01(r * kr), 0.5)); - rgb->g = dblToCol(pow(clip01(g * kg), 0.5)); - rgb->b = dblToCol(pow(clip01(b * kb), 0.5)); + rgb->r = dblToCol(sqrt(clip01(r * kr))); + rgb->g = dblToCol(sqrt(clip01(g * kg))); + rgb->b = dblToCol(sqrt(clip01(b * kb))); rgb->r = rgb->g = rgb->b = clip01(color->c[0]); } @@ -1246,9 +1246,9 @@ void GfxLabColorSpace::getRGB(GfxColor *color, GfxRGB *rgb) { r = xyzrgb[0][0] * X + xyzrgb[0][1] * Y + xyzrgb[0][2] * Z; g = xyzrgb[1][0] * X + xyzrgb[1][1] * Y + xyzrgb[1][2] * Z; b = xyzrgb[2][0] * X + xyzrgb[2][1] * Y + xyzrgb[2][2] * Z; - rgb->r = dblToCol(pow(clip01(r * kr), 0.5)); - rgb->g = dblToCol(pow(clip01(g * kg), 0.5)); - rgb->b = dblToCol(pow(clip01(b * kb), 0.5)); + rgb->r = dblToCol(sqrt(clip01(r * kr))); + rgb->g = dblToCol(sqrt(clip01(g * kg))); + rgb->b = dblToCol(sqrt(clip01(b * kb))); } void GfxLabColorSpace::getCMYK(GfxColor *color, GfxCMYK *cmyk) { ------------------------------ Message: 3 Date: Mon, 21 Jun 2010 23:50:22 +0100 From: Albert Astals Cid <<a href="mailto:aacid@kde.org">aacid@kde.org</a>> Subject: Re: [poppler] Patch go Get PDF ID To: <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a> Message-ID: <<a href="mailto:201006212350.23148.aacid@kde.org">201006212350.23148.aacid@kde.org</a>> Content-Type: Text/Plain; charset="us-ascii" A Dilluns, 21 de juny de 2010, srinivas adicherla va escriure: > Hi, > > I made some changes to the recent patch. I removed the function > setID(). > > > Please let me know when you commit this patch. > > Thanks & regards > A Srinivas Hi, some minor comments, just for safety + if (obj.isNull()) + { + obj.free(); + return NULL; + } should be + if (!obj.isArray()) + { + obj.free(); + return NULL; + } And you should be checking that val1 and val2 are strings too before doing getString(). And probably you want to call Set instead of append over permanent_id and update_id. Albert ------------------------------ _______________________________________________ poppler mailing list <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/poppler" target="_blank">http://lists.freedesktop.org/mailman/listinfo/poppler</a> End of poppler Digest, Vol 64, Issue 38 *************************************** </blockquote></div>