HI, Please don't consider the srinivas_poppler3.patch from the previous mail. I attached it here. Thanks -- A Srinivas <div class="gmail_quote">On Mon, Jul 5, 2010 at 3:33 PM, <<a href="mailto:poppler-request@lists.freedesktop.org">poppler-request@lists.freedesktop.org</a>> wrote: <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Send poppler mailing list submissions to <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a> To subscribe or unsubscribe via the World Wide Web, visit <a href="http://lists.freedesktop.org/mailman/listinfo/poppler" target="_blank">http://lists.freedesktop.org/mailman/listinfo/poppler</a> or, via email, send a message with subject or body 'help' to <a href="mailto:poppler-request@lists.freedesktop.org">poppler-request@lists.freedesktop.org</a> You can reach the person managing the list at <a href="mailto:poppler-owner@lists.freedesktop.org">poppler-owner@lists.freedesktop.org</a> When replying, please edit your Subject line so it is more specific than "Re: Contents of poppler digest..." Today's Topics: 1. 2 commits - glib/poppler-attachment.cc glib/poppler-document.cc glib/<a href="http://poppler-features.h.in" target="_blank">poppler-features.h.in</a> glib/poppler-media.cc glib/poppler-page.cc (Carlos Garcia Campos) 2. Patch to Get PDF ID (srinivas adicherla) ---------------------------------------------------------------------- Message: 1 Date: Mon, 5 Jul 2010 02:17:21 -0700 (PDT) From: <a href="mailto:carlosgc@kemper.freedesktop.org">carlosgc@kemper.freedesktop.org</a> (Carlos Garcia Campos) Subject: [poppler] 2 commits - glib/poppler-attachment.cc glib/poppler-document.cc glib/<a href="http://poppler-features.h.in" target="_blank">poppler-features.h.in</a> glib/poppler-media.cc glib/poppler-page.cc To: <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a> Message-ID: <<a href="mailto:20100705091721.4B6AE10057@kemper.freedesktop.org">20100705091721.4B6AE10057@kemper.freedesktop.org</a>> glib/poppler-attachment.cc | 4 ++-- glib/poppler-document.cc | 12 ++++++------ glib/<a href="http://poppler-features.h.in" target="_blank">poppler-features.h.in</a> | 6 ++++-- glib/poppler-media.cc | 4 ++-- glib/poppler-page.cc | 4 ++-- 5 files changed, 16 insertions(+), 14 deletions(-) New commits: commit 092aa901b9ec35a48bc1fb229ad16a3b00eef5f2 Author: Carlos Garcia Campos <<a href="mailto:carlosgc@gnome.org">carlosgc@gnome.org</a>> Date: Mon Jul 5 11:16:49 2010 +0200 [glib] docs: add some more introspection annotations diff --git a/glib/poppler-attachment.cc b/glib/poppler-attachment.cc index 6ff20b2..d3281ba 100644 --- a/glib/poppler-attachment.cc +++ b/glib/poppler-attachment.cc @@ -157,7 +157,7 @@ save_helper (const gchar *buf, * poppler_attachment_save: * @attachment: A #PopplerAttachment. * @filename: name of file to save - * @error: return location for error, or %NULL. + * @error: (allow-none): return location for error, or %NULL. * * Saves @attachment to a file indicated by @filename. If @error is set, %FALSE * will be returned. Possible errors include those in the #G_FILE_ERROR domain @@ -215,7 +215,7 @@ poppler_attachment_save (PopplerAttachment *attachment, * @attachment: A #PopplerAttachment. * @save_func: a function that is called to save each block of data that the save routine generates. * @user_data: user data to pass to the save function. - * @error: return location for error, or %NULL. + * @error: (allow-none): return location for error, or %NULL. * * Saves @attachment by feeding the produced data to @save_func. Can be used * when you want to store the attachment to something other than a file, such as diff --git a/glib/poppler-document.cc b/glib/poppler-document.cc index c013e25..288bf11 100644 --- a/glib/poppler-document.cc +++ b/glib/poppler-document.cc @@ -133,8 +133,8 @@ _poppler_document_new_from_pdfdoc (PDFDoc *newDoc, /** * poppler_document_new_from_file: * @uri: uri of the file to load - * @password: password to unlock the file with, or %NULL - * @error: Return location for an error, or %NULL + * @password: (allow-none): password to unlock the file with, or %NULL + * @error: (allow-none): Return location for an error, or %NULL * * Creates a new #PopplerDocument. If %NULL is returned, then @error will be * set. Possible errors include those in the #POPPLER_ERROR and #G_FILE_ERROR @@ -205,8 +205,8 @@ poppler_document_new_from_file (const char *uri, * poppler_document_new_from_data: * @data: the pdf data contained in a char array * @length: the length of #data - * @password: password to unlock the file with, or %NULL - * @error: Return location for an error, or %NULL + * @password: (allow-none): password to unlock the file with, or %NULL + * @error: (allow-none): Return location for an error, or %NULL * * Creates a new #PopplerDocument. If %NULL is returned, then @error will be * set. Possible errors include those in the #POPPLER_ERROR and #G_FILE_ERROR @@ -274,7 +274,7 @@ handle_save_error (int err_code, * poppler_document_save: * @document: a #PopplerDocument * @uri: uri of file to save - * @error: return location for an error, or %NULL + * @error: (allow-none): return location for an error, or %NULL * * Saves @document. Any change made in the document such as * form fields filled by the user will be saved. @@ -311,7 +311,7 @@ poppler_document_save (PopplerDocument *document, * poppler_document_save_a_copy: * @document: a #PopplerDocument * @uri: uri of file to save - * @error: return location for an error, or %NULL + * @error: (allow-none): return location for an error, or %NULL * * Saves a copy of the original @document. * Any change made in the document such as diff --git a/glib/poppler-media.cc b/glib/poppler-media.cc index ab2270a..a909dde 100644 --- a/glib/poppler-media.cc +++ b/glib/poppler-media.cc @@ -195,7 +195,7 @@ save_helper (const gchar *buf, * poppler_media_save: * @poppler_media: a #PopplerMedia * @filename: name of file to save - * @error: return location for error, or %NULL. + * @error: (allow-none): return location for error, or %NULL. * * Saves embedded stream of @poppler_media to a file indicated by @filename. * If @error is set, %FALSE will be returned. @@ -257,7 +257,7 @@ poppler_media_save (PopplerMedia *poppler_media, * @poppler_media: a #PopplerMedia * @save_func: a function that is called to save each block of data that the save routine generates. * @user_data: user data to pass to the save function. - * @error: return location for error, or %NULL. + * @error: (allow-none): return location for error, or %NULL. * * Saves embedded stream of @poppler_media by feeding the produced data to @save_func. Can be used * when you want to store the media clip stream to something other than a file, such as diff --git a/glib/poppler-page.cc b/glib/poppler-page.cc index b96a755..031edc7 100644 --- a/glib/poppler-page.cc +++ b/glib/poppler-page.cc @@ -84,8 +84,8 @@ poppler_page_finalize (GObject *object) /** * poppler_page_get_size: * @page: A #PopplerPage - * @width: return location for the width of @page - * @height: return location for the height of @page + * @width: (allow-none): return location for the width of @page + * @height: (allow-none): return location for the height of @page * * Gets the size of @page at the current scale and rotation. **/ commit 6c4e14fd90d5ef2d6670a980ab2476b6fab58df7 Author: Carlos Garcia Campos <<a href="mailto:carlosgc@gnome.org">carlosgc@gnome.org</a>> Date: Mon Jul 5 10:49:59 2010 +0200 [glib] docs: fix POPPLER_CHECK_VERSION() docs diff --git a/glib/<a href="http://poppler-features.h.in" target="_blank">poppler-features.h.in</a> b/glib/<a href="http://poppler-features.h.in" target="_blank">poppler-features.h.in</a> index 6ac0971..4cd37cd 100644 --- a/glib/<a href="http://poppler-features.h.in" target="_blank">poppler-features.h.in</a> +++ b/glib/<a href="http://poppler-features.h.in" target="_blank">poppler-features.h.in</a> @@ -79,8 +79,10 @@ * @minor: minor version (e.g. 1 for version 0.1.2) * @micro: micro version (e.g. 2 for version 0.1.2) * - * Returns %TRUE if the version of the poppler header files is the same - * as or newer than the passed-in version. + * Checks the version fo the poppler library + * + * Returns: %TRUE if the version of the poppler header files is the same + * as or newer than the passed-in version * * Since: 0.12 */ ------------------------------ Message: 2 Date: Mon, 5 Jul 2010 15:33:53 +0530 From: srinivas adicherla <<a href="mailto:srinivas.adicherla@gmail.com">srinivas.adicherla@gmail.com</a>> Subject: [poppler] Patch to Get PDF ID To: <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a> Message-ID: <<a href="mailto:AANLkTimT497jNKgw-4EAReomO0ZcBnhCOx_1GVHsuiOp@mail.gmail.com">AANLkTimT497jNKgw-4EAReomO0ZcBnhCOx_1GVHsuiOp@mail.gmail.com</a>> Content-Type: text/plain; charset="iso-8859-1" Hi, By considering valuable suggestions from all, I created 3 patches to get the ID from the PDF document. All patches do the same. But the implementation has different. I request all to give suggestions that which is the good way, and if there is any other better way please let me know. Explanation: patch1: Here I wrote getPermanentID() & getUpdateID() seperate functions. I called these from poppler-glib to get the entire ID and return the structure PopplerDocumentId. But here the repetetion of the code for getting "ID" object from trailer dictionary and check the conditions. To elimante that, pathc2: I wrote one more function getID(GooString *id, int index) in PDFDoc.cc, and calling this from getPermanentID() and getUpdateID(), by passing appropriate index. To eliminate this index thing, patch3: I declare one enum PDFID { permanentID, updateID } and remove getPermanentID() and getUpdateID() functions. Added getID(GooString *id, PDFID idType) Iam not at good in giving names to variable & functions. Please give me suggestions. Please let me know when you commit this patch. If any of the patch is considered from the above. Thanks -- A Srinivas -------------- next part -------------- An HTML attachment was scrubbed... URL: <<a href="http://lists.freedesktop.org/archives/poppler/attachments/20100705/b8b77fd4/attachment.html" target="_blank">http://lists.freedesktop.org/archives/poppler/attachments/20100705/b8b77fd4/attachment.html</a>> -------------- next part -------------- A non-text attachment was scrubbed... Name: srinivas_poppler1.patch Type: text/x-patch Size: 8781 bytes Desc: not available URL: <<a href="http://lists.freedesktop.org/archives/poppler/attachments/20100705/b8b77fd4/attachment.bin" target="_blank">http://lists.freedesktop.org/archives/poppler/attachments/20100705/b8b77fd4/attachment.bin</a>> -------------- next part -------------- A non-text attachment was scrubbed... Name: srinivas_poppler2.patch Type: text/x-patch Size: 8294 bytes Desc: not available URL: <<a href="http://lists.freedesktop.org/archives/poppler/attachments/20100705/b8b77fd4/attachment-0001.bin" target="_blank">http://lists.freedesktop.org/archives/poppler/attachments/20100705/b8b77fd4/attachment-0001.bin</a>> -------------- next part -------------- A non-text attachment was scrubbed... Name: srinivas_poppler3.patch Type: text/x-patch Size: 8413 bytes Desc: not available URL: <<a href="http://lists.freedesktop.org/archives/poppler/attachments/20100705/b8b77fd4/attachment-0002.bin" target="_blank">http://lists.freedesktop.org/archives/poppler/attachments/20100705/b8b77fd4/attachment-0002.bin</a>> ------------------------------ _______________________________________________ poppler mailing list <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/poppler" target="_blank">http://lists.freedesktop.org/mailman/listinfo/poppler</a> End of poppler Digest, Vol 65, Issue 8 ************************************** </blockquote></div>