<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
Am 29.12.2010 15:11, schrieb Albert Astals Cid:
<blockquote cite="mid:201012291411.58139.aacid@kde.org" type="cite">
<pre wrap="">A Dimecres, 29 de desembre de 2010, Albert Astals Cid va escriure:
</pre>
<blockquote type="cite">
<pre wrap="">A Dimecres, 29 de desembre de 2010, Thomas Freitag va escriure:
</pre>
<blockquote type="cite">
<pre wrap="">Am 29.12.2010 10:13, schrieb Thomas Freitag:
</pre>
<blockquote type="cite">
<pre wrap="">Am 28.12.2010 16:51, schrieb Albert Astals Cid:
</pre>
<blockquote type="cite">
<pre wrap="">A Dimarts, 28 de desembre de 2010, vàreu escriure:
</pre>
<blockquote type="cite">
<pre wrap="">Am 27.12.2010 19:40, schrieb Albert Astals Cid:
</pre>
<blockquote type="cite">
<pre wrap="">A Dilluns, 27 de desembre de 2010, Thomas Freitag va escriure:
</pre>
<blockquote type="cite">
<pre wrap="">Thanks for immediately starting regtesting.
Thought You're in xmas vacation or have enough to do releasing
0.16.0.
Here the correction for the artefacts by pdftoppm, I made a small
mistake when optimizing my code.
</pre>
</blockquote>
<pre wrap="">
Found some more problems, i found a pdf in which it seems that a
circle
is not totally filled, sending you the files.
Albert
</pre>
</blockquote>
<pre wrap="">
Playing once again patch ping pong with You. Hope, we can finish the
game until end of this week :-)
This PDF was a real headscratcher: Okay, I had some rounding problems
calculating the size of the bitmap needed for the pattern. But that
wasn't the main reason. The main reason was that only the half of the
circles are painted with radial pattern, and the clipping path was
exactly on the diameter and the outer line of the circle. Therefore
the use antialiasing has the effect, that is seems that the circles
are not totally filled. You can see that in the middle line of the
circles with the former patch.
Because there is no way to decide on the values of the shading
parameters wether to use antialiasing or not, I changed my mind with
heavy heart not using antialiasing on radial shading pattern. At
least the wine glass is still looking better.
</pre>
</blockquote>
<pre wrap="">
I'm getting a out of memory error when rendering the second page of
9af89586e41a631f6b114a7f7bc5beaf 1und1_DSL_Flyer_partner.pdf
i think you sent me this file, if you need it mail me and i'll send
it back to
you again.
</pre>
</blockquote>
<pre wrap="">
No, I didn't send You this file, but You already sent me the link to
it because of bug 27208, so I have it.
</pre>
<blockquote type="cite">
<pre wrap="">The problem seems to be that when you calculate the scale in
SplashRadialPattern constructor it ends up being infinite which in
tourn tries
to allocate a bitmap of infxinf in size which fails :D
</pre>
</blockquote>
<pre wrap="">
Yes, You're true. Changing the order a little bit, calculating width &
height before rounding the bounding box, solves it:
width = xMax - xMin;
height = yMax - yMin;
xMin = splashRound(xMin);
xMax = splashRound(xMax);
yMin = splashRound(yMin);
yMax = splashRound(yMax);
BUT: pdftoppm crashes with page two in Splash::blitTransparent(), so
not in the new routines, but I want to solve that, too, before sending
You a complete new patch.
</pre>
</blockquote>
<pre wrap="">
I have it: The problem is in SplashOutputDev::beginTransparencyGroup, if
ty > bitmap->getHeight(), ty is set to ty = bitmap->getHeight(). But
that means that in Splash::blitTransparent() one line behind the bitmap
is copied. I don't really know, if it is better to copy nothing or to
copy just the last line, but copying nothing probably leads to other
problems in endTransparencyGroup, so it's easier to copy just the last
line. But if this causes new regressions, we can try to change that. So
please regtest the new patch.
BTW, I change the constructor of SplashRadialPattern a little bit more
to not only avoid infinite values.
</pre>
</blockquote>
<pre wrap="">
Running on the same 1und1 pdf, in the second page the printer paper has a
quite big rendering change and Adobe Reader seems to agree with the old
rendering. Can you have a look at that?
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
I made a mistake when solving the problem with
altona_visual_1v2a_x3.pdf. I find now a better way to solve it,
which also gives a better look of the printer paper back again.<br>
<br>
Hope You are still willing to support this patch.<br>
<br>
Thomas <br>
<blockquote cite="mid:201012291411.58139.aacid@kde.org" type="cite">
<pre wrap="">Attaching the new and old rendering since reading again my mail seemed a bit
unclear where the problem might be.
Albert
</pre>
<blockquote type="cite">
<pre wrap="">
Albert
</pre>
<blockquote type="cite">
<pre wrap="">Thomas
</pre>
<blockquote type="cite">
<pre wrap="">Thomas
</pre>
<blockquote type="cite">
<pre wrap="">Albert
</pre>
<blockquote type="cite">
<pre wrap="">Please try the new attached patch,
Thomas
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">Thomas
Am 27.12.2010 02:07, schrieb Albert Astals Cid:
</pre>
<blockquote type="cite">
<pre wrap="">A Dilluns, 27 de desembre de 2010, Albert Astals Cid va escriure:
</pre>
<blockquote type="cite">
<pre wrap="">A Diumenge, 26 de desembre de 2010, Thomas Freitag va escriure:
</pre>
<blockquote type="cite">
<pre wrap="">Am 04.11.2010 22:26, schrieb Albert Astals Cid:
</pre>
<blockquote type="cite">
<pre wrap="">Hi, i just commited the patch to splash with antialias and
shadings,
really good work!
Now, it seems you are both magicians so i'm asking another
wish :D
Of course only do this if you feel like it's fun ;-)
Have a look at the ducks and roses at
<a class="moz-txt-link-freetext" href="http://www.acquerra.com.au/poppler/img_0.pdf">http://www.acquerra.com.au/poppler/img_0.pdf</a>
Do you guys feel like trying to fix it?
Albert
</pre>
</blockquote>
<pre wrap="">
Hi Albert!
As I already mentioned, I had a deeper look at the ducks&
roses,
and espially at the wine glass.
I encountered, that there is no way to solve that in Gfx.cc, and
therefore I implemented radial shading in SplashOutputDev now.
It took me "some" days, more effort then I thought before
beginning, but the result is really beautiful, therefore I
attach not only the
patch but the rendering result too, so that You can immediately
what I mean with beautiful :-)
Take it a belated xmas gift for the poppler community :-)
</pre>
</blockquote>
<pre wrap="">
Good work :-)
I've found a regression though, if you run pdftotext with and
without
the pdf file i'll send you in private, you'll see that the lower
left
square has some "random" white pixels that are not there without
the
patch.
</pre>
</blockquote>
<pre wrap="">
s/pdftotext/pdftoppm :D
Albert
</pre>
<blockquote type="cite">
<pre wrap="">Albert
</pre>
<blockquote type="cite">
<pre wrap="">Best regards,
Thomas
</pre>
</blockquote>
<pre wrap="">
_______________________________________________
poppler mailing list
<a class="moz-txt-link-abbreviated" href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/poppler">http://lists.freedesktop.org/mailman/listinfo/poppler</a>
</pre>
</blockquote>
<pre wrap="">
_______________________________________________
poppler mailing list
<a class="moz-txt-link-abbreviated" href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/poppler">http://lists.freedesktop.org/mailman/listinfo/poppler</a>
..
</pre>
</blockquote>
</blockquote>
<pre wrap="">
_______________________________________________
poppler mailing list
<a class="moz-txt-link-abbreviated" href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/poppler">http://lists.freedesktop.org/mailman/listinfo/poppler</a>
..
</pre>
</blockquote>
</blockquote>
<pre wrap="">
_______________________________________________
poppler mailing list
<a class="moz-txt-link-abbreviated" href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/poppler">http://lists.freedesktop.org/mailman/listinfo/poppler</a>
..
</pre>
</blockquote>
<pre wrap="">
_______________________________________________
poppler mailing list
<a class="moz-txt-link-abbreviated" href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/poppler">http://lists.freedesktop.org/mailman/listinfo/poppler</a>
..
</pre>
</blockquote>
</blockquote>
<pre wrap="">
_______________________________________________
poppler mailing list
<a class="moz-txt-link-abbreviated" href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/poppler">http://lists.freedesktop.org/mailman/listinfo/poppler</a>
</pre>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
poppler mailing list
<a class="moz-txt-link-abbreviated" href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/poppler">http://lists.freedesktop.org/mailman/listinfo/poppler</a>
</pre>
</blockquote>
</blockquote>
<br>
</body>
</html>