Hi Albert Actually I didn't get any warnings about accessing png info structure variables. I think in some old versions it may occur. But for safety reason I replaced them with the functions. Please find the new patch attached with this mail. Thanks -- A Srinivas <div class="gmail_quote">On Wed, Mar 16, 2011 at 12:30 AM, <<a href="mailto:poppler-request@lists.freedesktop.org">poppler-request@lists.freedesktop.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Send poppler mailing list submissions to <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a> To subscribe or unsubscribe via the World Wide Web, visit <a href="http://lists.freedesktop.org/mailman/listinfo/poppler" target="_blank">http://lists.freedesktop.org/mailman/listinfo/poppler</a> or, via email, send a message with subject or body 'help' to <a href="mailto:poppler-request@lists.freedesktop.org">poppler-request@lists.freedesktop.org</a> You can reach the person managing the list at <a href="mailto:poppler-owner@lists.freedesktop.org">poppler-owner@lists.freedesktop.org</a> When replying, please edit your Subject line so it is more specific than "Re: Contents of poppler digest..." Today's Topics: 1. Re: Patch for embedding videos in to the pdf (Albert Astals Cid) ---------------------------------------------------------------------- Message: 1 Date: Mon, 14 Mar 2011 22:12:10 +0000 From: Albert Astals Cid <<a href="mailto:aacid@kde.org">aacid@kde.org</a>> Subject: Re: [poppler] Patch for embedding videos in to the pdf To: <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a> Message-ID: <<a href="mailto:201103142212.10597.aacid@kde.org">201103142212.10597.aacid@kde.org</a>> Content-Type: Text/Plain; charset="utf-8" A Dilluns, 14 de mar? de 2011, Albert Astals Cid va escriure: > A Dijous, 10 de mar? de 2011, srinivas adicherla va escriure: > > Hi Albert > > > > Sorry I forgot to remove xrefA from 'load_from_png'. And I > > > > check if the > > video_name is null iam assigning video_name = video_file > > > > Thanks > > Looks good to me now, if noone disagrees i'll commit it to master in the > next 24 hours or so. Actually i disagree :D Can you please fix these warnings /home/tsdgeos/devel/poppler/poppler/Annot.cc: In function ?MemStream* load_from_png(FILE*, Object*)?: /home/tsdgeos/devel/poppler/poppler/Annot.cc:4147:17: warning: ?png_info_struct::color_type? is deprecated (declared at /usr/include/png.h:661) /home/tsdgeos/devel/poppler/poppler/Annot.cc:4147:17: warning: ?png_info_struct::color_type? is deprecated (declared at /usr/include/png.h:661) /home/tsdgeos/devel/poppler/poppler/Annot.cc:4150:25: warning: ?png_info_struct::width? is deprecated (declared at /usr/include/png.h:647) /home/tsdgeos/devel/poppler/poppler/Annot.cc:4150:25: warning: ?png_info_struct::width? is deprecated (declared at /usr/include/png.h:647) /home/tsdgeos/devel/poppler/poppler/Annot.cc:4151:26: warning: ?png_info_struct::height? is deprecated (declared at /usr/include/png.h:648) /home/tsdgeos/devel/poppler/poppler/Annot.cc:4151:26: warning: ?png_info_struct::height? is deprecated (declared at /usr/include/png.h:648) /home/tsdgeos/devel/poppler/poppler/Annot.cc:4162:47: warning: ?png_info_struct::rowbytes? is deprecated (declared at /usr/include/png.h:651) /home/tsdgeos/devel/poppler/poppler/Annot.cc:4162:47: warning: ?png_info_struct::rowbytes? is deprecated (declared at /usr/include/png.h:651) /home/tsdgeos/devel/poppler/poppler/Annot.cc:4167:74: warning: ?png_info_struct::rowbytes? is deprecated (declared at /usr/include/png.h:651) /home/tsdgeos/devel/poppler/poppler/Annot.cc:4167:74: warning: ?png_info_struct::rowbytes? is deprecated (declared at /usr/include/png.h:651) /home/tsdgeos/devel/poppler/poppler/Annot.cc:4175:17: warning: ?png_info_struct::channels? is deprecated (declared at /usr/include/png.h:672) /home/tsdgeos/devel/poppler/poppler/Annot.cc:4175:17: warning: ?png_info_struct::channels? is deprecated (declared at /usr/include/png.h:672) /home/tsdgeos/devel/poppler/poppler/Annot.cc:4180:62: warning: ?png_info_struct::bit_depth? is deprecated (declared at /usr/include/png.h:659) /home/tsdgeos/devel/poppler/poppler/Annot.cc:4180:62: warning: ?png_info_struct::bit_depth? is deprecated (declared at /usr/include/png.h:659) Albert > Albert > _______________________________________________ > poppler mailing list > <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a> > <a href="http://lists.freedesktop.org/mailman/listinfo/poppler" target="_blank">http://lists.freedesktop.org/mailman/listinfo/poppler</a> ------------------------------ _______________________________________________ poppler mailing list <a href="mailto:poppler@lists.freedesktop.org">poppler@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/poppler" target="_blank">http://lists.freedesktop.org/mailman/listinfo/poppler</a> End of poppler Digest, Vol 73, Issue 23 *************************************** </blockquote></div>