<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi,<br>
<br>
I got the attached hint from Anthony, and I agreed, so I created the
attached one line patch.<br>
Please insert the copyright notice of Anthony, I don't want to adorn
myself with borrowed plumes :-)<br>
<br>
Cheers,<br>
Thomas<br>
<br>
<a href="http://www.dict.cc/englisch-deutsch/plumes.html"></a>On
16.05.2012 06:48, Anthony Wesley wrote:
<blockquote cite="mid:4FB33190.8060400@smartnetworks.com.au"
type="cite">Hi Thomas, hope you don't mind me emailing you direct
about this, there is a simple coding error in SplashBitmap.cc, in
the function
<br>
<br>
SplashError SplashBitmap::writeImgFile(ImgWriter *writer, FILE *f,
int hDPI, int vDPI)
<br>
<br>
on line 522 (close to the end of the file) the test for error
condition on closing the writer is the wrong way around. The code
should say:
<br>
<br>
if (! writer->close()) {
<br>
return splashErrGeneric;
<br>
}
<br>
<br>
<br>
as the code is currently written this function always returns
SplashErrorGeneric.
<br>
<br>
regards, Anthony
<br>
<br>
</blockquote>
<br>
</body>
</html>