<div dir="ltr"><div><div>Thanks. And here's the patch.<br><br><br></div>regards,<br></div>- Lu<br><div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Jan 27, 2013 at 12:58 AM, Thomas Freitag <span dir="ltr"><<a href="mailto:Thomas.Freitag@kabelmail.de" target="_blank">Thomas.Freitag@kabelmail.de</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Am 26.01.2013 16:59, schrieb Albert Astals Cid:<div><br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> El Dissabte, 26 de gener de 2013, a les 22:53:22, 王璐 va escriure:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> I mean it's confusing and not well documented.<br> Might waste people's time in the following work of poppler, or potential<br> bugs etc.<br> <br> At least a warning comment there would be helpful.<br> <br> But as you mentioned, shiftCTMAndClip is good enough to me.<br> </blockquote> Thomas, anything against the rename? It is true that this function does a bit<br> more than the other xyzCTM, I agree with you that it's not really a priority<br> but i don't think it hurts either.<br> </blockquote></div> If it's confusing for someone, why not? Splash just need the functionality and not the name :-)<br> <br> Cheers,<br> Thomas<div><div><br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Cheers,<br> Albert<br> <br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> <br> <br> regards,<br> - Lu<br> <br> On Sat, Jan 26, 2013 at 8:56 PM, Albert Astals Cid <<a href="mailto:aacid@kde.org" target="_blank">aacid@kde.org</a>> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> El Dissabte, 26 de gener de 2013, a les 20:40:14, 王璐 va escriure:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Hi all,<br> <br> In GfxState.h, this function is declared right after setCTM and<br> <br> concatCTM, which looks like no big deal than the other 2, but actually<br> </blockquote> also<br> <br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> modifies clip BBox of the State<br> <br> The only place this function is used is in the functions handling<br> <br> transparency groups in SplashOutputDev.cc. I'm not familiar with that<br> </blockquote> part,<br> <br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> but looks like an ad hoc hack.<br> <br> I found this while I want to track all functions that might update<br> </blockquote> clip<br> <br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> BBox, this does not make sense to me. Although I've got no better<br> </blockquote> solution,<br> <br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> at least it might be more reasonable if we add a new backdoor for clip<br> </blockquote> BBox<br> <br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> and change shiftCTM to what it looks like. In this way SplashOutputDev<br> still takes the responsibility, but GfxState is relieved.<br> <br> What do you think ? I can create a patch.<br> </blockquote> Why do you think this is a problem?<br> <br> <br> To be honest i don't see any need for a change, all these functions are<br> internal and not supposed to be used outside the inner world of poppler<br> itself, so the function is doing what it should do.<br> <br> At most we could rename the function, and name it something like<br> shiftCTMAndClip or something, would that work for you?<br> <br> Cheers,<br> <br> Albert<br> <br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> regards,<br> - Lu<br> </blockquote> ______________________________<u></u>_________________<br> poppler mailing list<br> <a href="mailto:poppler@lists.freedesktop.org" target="_blank">poppler@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/poppler" target="_blank">http://lists.freedesktop.org/<u></u>mailman/listinfo/poppler</a><br> </blockquote></blockquote> ______________________________<u></u>_________________<br> poppler mailing list<br> <a href="mailto:poppler@lists.freedesktop.org" target="_blank">poppler@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/poppler" target="_blank">http://lists.freedesktop.org/<u></u>mailman/listinfo/poppler</a><br> </blockquote> <br> <br> ______________________________<u></u>_________________<br> poppler mailing list<br> <a href="mailto:poppler@lists.freedesktop.org" target="_blank">poppler@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/poppler" target="_blank">http://lists.freedesktop.org/<u></u>mailman/listinfo/poppler</a><br> </div></div></blockquote></div><br></div></div></div></div></div>