<html> <head> <style></style></head> <body class='hmmessage'><div dir='ltr'>I noticed that the files were all in MSDOS format with CR-LF line endings, which corrupted the PDF, but I could fix it in emacs.<div><br></div><div>Do you have sample files in all four orientations? I think that it would be good to exercise all of the code.</div><div><br></div><div>Does the problem happen only when the -paper option is used because pdftops shifts the image but (without your patch) does not make the corresponding changes to the bounding box?</div><div><br></div><div>I noticed that you changed a sequence "if (rotate == 0) { } else if (rotate == 90) {} etc" into a "switch (rotate) { case 0: ... case 90: ... case 180: ... etc }". I learned C in the old days on a pdp11 where a switch like that could generate a huge jump table. Is that still an issue?</div><div><br></div><div>Regards,</div><div>William</div><div><br><br><div>From: Bugzilla@pahlx.de<br>To: poppler@lists.freedesktop.org; ajohnson@redneon.com<br>Date: Sat, 24 Oct 2015 18:28:07 +0200<br>Subject: Re: [poppler] Printing of certain PDF files does not work with "fit-to-page" because of wrong BoundingBox values in the PostScript<br><br><pre>Attached you find an example:<br> <br>example.pdf: a box generated with xfig 321mm x 106mm<br> <br>example.ps generated with pdftops -paper A4 example.pdf<br>example.ps:%%PageBoundingBox: 0 0 302 912<br> <br>example-patched.ps generated with pdftops -paper A4 example.pdf, but with the <br>patched version.<br>example-patched.ps:%%PageBoundingBox: 158 0 437 842<br> <br>You can view the postscript files with gv and select BBox. It's obvious that <br>the unpatched PageBoundingBox is totally wrong, because source coordinates are <br>used. The PageBoundingBox is bigger then the A4 paper format. It's just the <br>size of the original box (302 /72 dpi * 25,4mm = 106,5mm; 912/72 dpi * 25,4mm <br>= 321,73mm). But it must be the box scaled down to A4 and shifted to the <br>center.<br> <br>Hope this example helps.<br> <br>Regards,<br> <br>Martin Pahl<br> <br> <br>Am Freitag, 23. Oktober 2015, 21:46:02 schrieb Adrian Johnson:<br>> On 21/10/15 03:32, Stefan Brandner wrote:<br>> > ------------------------------------------------------------------------<br>> > <br>> > I am using the patch now for several month and I can prove it is working<br>> > fine. So if the code quality is ok for you Albert why not pushing it?<br>> > <br>> > Regards<br>> > Stefan Brandner<br>> <br>> I'll take a look at the patch sometime in the next week. It would help<br>> if you:<br>> <br>> - attach a PDF that reproduces the bug<br>> - list the pdftops options you are using<br>> - list the bounding box output you are getting and what you think<br>> it should be.<br>> <br>> > El Dijous, 7 de maig de 2015, a les 09:34:09, Martin Pahl va escriure:<br>> >>/Hi, />//>/I sent patches to fix the bug:<br>> >>/>//>/<a href="https://bugs.freedesktop.org/show_bug.cgi?id=87161" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=87161</a> />//>/Those<br>> >>patches were automatically sent to poppler-bugs mailing list. But>><br>> > as I />/see no reaction to my patch submission (poppler-bugs seems to be a<br>> > />/mailinglist without human interaction) I just want to ask, what is the<br>> > />/right way to submit patches. / It is.<br>> > <br>> > What we need is more people with time to review patches.<br>> > <br>> > Cheers,<br>> > <br>> > Albert<br>> >><br>> >>/By the way this bug is really annoying as it makes all PDF viewers using<br>> >>/>/poppler useless for printing documents that do not have the page size<br>> >>of>><br>> > the />/output device (e.g. printer). On the other hand acroread is not an<br>> > />/alternative anymore as Adobe has discontinued support for Linux.<br>> > />//>/Regards, />//>/Martin Pahl /<br>> > <br>> > <br>> > <br>> > _______________________________________________<br>> > poppler mailing list<br>> > poppler@lists.freedesktop.org<br>> > <a href="http://lists.freedesktop.org/mailman/listinfo/poppler" target="_blank">http://lists.freedesktop.org/mailman/listinfo/poppler</a><br>> <br>> _______________________________________________<br>> poppler mailing list<br>> poppler@lists.freedesktop.org<br>> <a href="http://lists.freedesktop.org/mailman/listinfo/poppler" target="_blank">http://lists.freedesktop.org/mailman/listinfo/poppler</a><br></pre><br>_______________________________________________ poppler mailing list poppler@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/poppler</div></div> </div></body> </html>