<html>
    <head>
      <base href="https://bugs.freedesktop.org/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Priority</th>
          <td>medium
          </td>
        </tr>

        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - XFCE .desktop file created for browser selection is broken"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=56092">56092</a>
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>portland-bugs@lists.freedesktop.org
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>XFCE .desktop file created for browser selection is broken
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Unclassified
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Linux (All)
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>random832@fastmail.us
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>1.1.0 rc1
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>xdg-utils
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>Portland
          </td>
        </tr></table>
      <p>
        <div>
        <pre>XFCE requires a special format of .desktop file for what it calls "helpers".
This requirement is handled by the check_xfce_desktop_file function in
xdg-settings. The function "converts" an existing application .desktop file by
removing the Type line and adding the so-called custom tweaks it requires.

This breaks when the application .desktop file has multiple sections (for
example, the chromium-browser.desktop that is present on Ubuntu).

I propose that instead of "converting" an existing application .desktop file,
when an existing XFCE helper .desktop file is not found it should create a
minimal one with only the necessary content. This would match more closely to
what what is done by XFCE's own preferred applications GUI when you browse for
a path to select a browser. It should be noted that the GUI always creates
"custom-WebBrowser.desktop" rather than [application].desktop, but this
behavior does not appear to be important and I am not sure yet if it is
desirable (I need to do more testing with how Chromium detects that it is not
the default browser to be sure).

I have already started working on a new version of this function, but have not
finished testing yet. I will attach it later this week.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>