[pulseaudio-tickets] [PulseAudio] #818: syntax error in rtp.c

PulseAudio trac-noreply at tango.0pointer.de
Sat May 8 03:08:34 PDT 2010


#818: syntax error in rtp.c
--------------------+-------------------------------------------------------
 Reporter:  pino    |       Owner:  lennart     
     Type:  defect  |      Status:  new         
Milestone:          |   Component:  module-rtp-*
 Keywords:          |  
--------------------+-------------------------------------------------------
 In the pa_rtp_recv() function of rtp.c there is:

     for (cm = CMSG_FIRSTHDR(&m); cm; cm = CMSG_NXTHDR(&m, cm)) {
         if (cm->cmsg_level == SOL_SOCKET && cm->cmsg_type == SO_TIMESTAMP)
             memcpy(tstamp, CMSG_DATA(cm), sizeof(struct timeval));
             found_tstamp = TRUE;
             break;
         }

 There is one opening and one closing brackets less, so the loop will set
 found_tstamp TRUE and break just after the first iteration, no matter
 whether the current cmsghdr had the right payload.

-- 
Ticket URL: <http://pulseaudio.org/ticket/818>
PulseAudio <http://pulseaudio.org/>
The PulseAudio Sound Server


More information about the pulseaudio-bugs mailing list