[pulseaudio-tickets] [Bug 39797] module-cork-music-on-phone unable to send CORK event to pulsesink for PA_STREAM_START_CORKED streams

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39797

--- Comment #11 from Colin Guthrie <fdo at colin.guthr.ie> 2011-08-23 10:27:32 PDT ---
(In reply to comment #10)
> (In reply to comment #9)
> > Yeah the cork event is never sent as module-cork-music-on-phone notices that
> > the stream is already corked and thus it doesn't do any more.
> 
> Why doesn't module-cork-music-on-phone send the cork request always, even if
> the stream is already corked? What possible harm could that do? If the request
> would be sent always, the client would at least have a chance to work around
> the shortcomings of the protocol.

Because the opposite would also have to be true - i.e. always sending the
uncork request. If that is the case and the client does not implement cork
request counting then you'd instantly get several clients incorrectly unpausing
music players at the end of calls even if the music had not been playing when
the call came in.

Not saying it's not a good idea generally, but it would have to be documented
quite clearly.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.