[pulseaudio-tickets] [Bug 88813] New: pavucontrol crashes on startup, if icon loading fails

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=88813

            Bug ID: 88813
           Summary: pavucontrol crashes on startup, if icon loading fails
           Product: PulseAudio
           Version: unspecified
          Hardware: All
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: pavucontrol
          Assignee: pulseaudio-bugs at lists.freedesktop.org
          Reporter: martin at steghoefer.eu
        QA Contact: pulseaudio-bugs at lists.freedesktop.org
                CC: lennart at poettering.net

Created attachment 112862
  --> https://bugs.freedesktop.org/attachment.cgi?id=112862&action=edit
Patch that extends the fallback behaviour on failed icon loading to exceptions
of type "Gdk::PixbufError"

Due to another bug [1] the MIME type guessing of PNG files was broken on my
Ubuntu system. This made pavucontrol crash on startup (while loading the
necessary icons) without a helpful error message (requiring a lot of debugging
effort). Although this is not originally pavucontrol's fault, I think that
pavucontrol could be more robust about such a problem, especially because: A)
In a complex database like the one to guess MIME types (that is populated from
hundres of different packages) this can happen from time to time and B)
pavucontrol already has some fallback options in place - they are just not
active in this specific case.

Specifically, the function "set_icon_name_fallback" already catches several
exceptions ("Gtk::IconThemeError" and "Gio::Error") about failed loading of
icons and falls back to just setting the name and using a default icon. I think
it's in the spirit of that code to extend that behaviour to the additional
exception type "Gdk::PixbufError", which is the exception that is thrown, if an
icon cannot be loaded due to broken MIME type guessing. Find a patch attached
that implements this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20150126/13ca11ff/attachment.html>