[pulseaudio-tickets] [Bug 96873] tcp transport always fails: PULSE_SERVER=127.0.0.1 src/pacat, Connection failure: Connection terminated

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=96873

--- Comment #4 from Sergei Trofimovich <slyfox at inbox.ru> ---
Bisected kernel down to bad commit:
   
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c14ac9451c34832554db33386a4393be8bba3a7b

I think tcp.c is where we have started getting -EINVAL:
   
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/diff/net/ipv4/tcp.c?id=c14ac9451c34832554db33386a4393be8bba3a7b

I guess tcp used to ignore control messages completely and now
it's unhappy about those.

I've failed to revert c14ac9451c34832554db33386a4393be8bba3a7b
properly but adding the following workaround allows pulseaudio
work over TCP:

diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 5c7ed14..1bec47c 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -1122,15 +1122,15 @@ int tcp_sendmsg(struct sock *sk, struct msghdr *msg,
size_t size)
                if (tp->repair_queue == TCP_NO_QUEUE)
                        goto out_err;

                /* 'common' sending to sendq */
        }

        sockc.tsflags = sk->sk_tsflags;
-       if (msg->msg_controllen) {
+       if (0 && msg->msg_controllen) {
                err = sock_cmsg_send(sk, msg, &sockc);
                if (unlikely(err)) {
                        err = -EINVAL;
                        goto out_err;
                }
        }


# bad: [ee40fb2948fc99096836995d4f3ddcc0efbac790] Merge tag 'scsi-fixes' of
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
# good: [2dcd0af568b0cf583645c8a317dd12e344b1c72a] Linux 4.6
git bisect start 'master' 'v4.6'
# bad: [6eb59af580dcffc6f6982ac8ef6d27a1a5f26b27] Merge tag 'mfd-for-linus-4.7'
of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd
git bisect bad 6eb59af580dcffc6f6982ac8ef6d27a1a5f26b27
# bad: [a7fd20d1c476af4563e66865213474a2f9f473a4] Merge
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
git bisect bad a7fd20d1c476af4563e66865213474a2f9f473a4
# bad: [9dc0b289c4c09bc1a92bdcc055cb37af9b72eb28] net/mlx5_core: Firmware
commands to support flow counters
git bisect bad 9dc0b289c4c09bc1a92bdcc055cb37af9b72eb28
# bad: [4319a7976722f6925b5bbbdac417d87a0cbde859] ixgbe: Add work around for
empty SFP+ cage crosstalk
git bisect bad 4319a7976722f6925b5bbbdac417d87a0cbde859
# bad: [bddf59046d804638d998f9015246d4990f1cab09] Merge tag
'wireless-drivers-next-for-davem-2016-04-11' of
git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next
git bisect bad bddf59046d804638d998f9015246d4990f1cab09
# bad: [307c2431abf0974996356c13b67432f4b35e5f2f] mlxsw: Pass mlxsw_core as a
param of mlxsw_core_skb_transmit*
git bisect bad 307c2431abf0974996356c13b67432f4b35e5f2f
# bad: [afb8ece4326f2151771f4c40b8d9f799cee5ae6e] i40e: remove redundant check
on vsi->active_vlans
git bisect bad afb8ece4326f2151771f4c40b8d9f799cee5ae6e
# bad: [532182cd610782db8c18230c2747626562032205] tcp: increment sk_drops for
dropped rx packets
git bisect bad 532182cd610782db8c18230c2747626562032205
# bad: [88023beb2a467dcfd9aa958138f0f3b5e1c432e0] net: macb: Fix simple typo
git bisect bad 88023beb2a467dcfd9aa958138f0f3b5e1c432e0
# good: [91979b9db86340d7cd49392a498663fb1ac74639] stmmac: update MAINTAINERS
git bisect good 91979b9db86340d7cd49392a498663fb1ac74639
# bad: [c14ac9451c34832554db33386a4393be8bba3a7b] sock: enable timestamping
using control messages
git bisect bad c14ac9451c34832554db33386a4393be8bba3a7b
# good: [6b084928baac562ed61866f540a96120e9c9ddb7] tcp: use one bit in
TCP_SKB_CB to mark ACK timestamps
git bisect good 6b084928baac562ed61866f540a96120e9c9ddb7
# good: [24025c465f77c3585f73450bab19501b2edd6fba] ipv4: process socket-level
control messages in IPv4
git bisect good 24025c465f77c3585f73450bab19501b2edd6fba
# good: [ad1e46a837163a3e7160a1250825bcfafd2e714b] ipv6: process socket-level
control messages in IPv6
git bisect good ad1e46a837163a3e7160a1250825bcfafd2e714b
# first bad commit: [c14ac9451c34832554db33386a4393be8bba3a7b] sock: enable
timestamping using control messages

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20160710/654dd8f2/attachment.html>