[pulseaudio-tickets] [Bug 100451] module-switch-on-port-available will only select unavailable ports when a new sink or source appears

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100451

--- Comment #1 from Tanu Kaskinen <tanuk at iki.fi> ---
I believe you misunderstood the intention of the code (which is no wonder -
comments would be very welcome here).

If the name parameter of new_sink_source() is set, then that means that some
other module has already chosen the initial port. If so,
module-switch-on-port-available shouldn't override that, unless the chosen port
is unavailable.

The function works correctly as far as I can tell. In the bug title you say
that the function selects unavailable ports, but to me that seems to be
possible only if all ports are unavailable.

The code seems a bit weird if the only purpose is to prevent other modules from
selecting unavailable ports, and if that's indeed the only purpose, I think it
would be better to fix those other modules and not worry about the initial port
at all in module-switch-on-port-available.

I don't understand how your change could result in better port choices. Details
about what ports exist on your system, the availability status of the ports,
and the choices made before and after your change would be helpful.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20170329/5ae68af9/attachment.html>