<html>
    <head>
      <base href="https://bugs.freedesktop.org/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Priority</th>
          <td>medium
          </td>
        </tr>

        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - [cleanup] pa_bluetooth_device.device_info_valid is a bit broken"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=58885">58885</a>
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>lennart@poettering.net
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>pulseaudio-bugs@lists.freedesktop.org
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>[cleanup] pa_bluetooth_device.device_info_valid is a bit broken
          </td>
        </tr>

        <tr>
          <th>QA Contact</th>
          <td>pulseaudio-bugs@lists.freedesktop.org
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Unclassified
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>tanuk@iki.fi
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>Other
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>unspecified
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>modules
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>PulseAudio
          </td>
        </tr></table>
      <p>
        <div>
        <pre>The pa_bluetooth_device.device_info_valid is supposed to tell whether we have
received the device properties properly from bluetoothd. Currently "properly"
means that the device name and address have been received. I think the
definition of "properly" should be more strict: we should fail if not *all*
interesting properties have been received. It is a bug in bluetoothd if it
doesn't send all non-optional properties, so it would be appropriate to fail in
case we detect bugs instead of pretending that everything is ok. For example,
if the UUID list of a device is not sent, pulseaudio acts as if the list is
empty, while in reality it's unknown. Pulseaudio should complain loudly if it
doesn't receive the UUID list, because it makes the device unusable.

What should the set of "interesting" properties be? I'd say any properties that
pulseaudio uses. This should be the same set of properties that pulseaudio
parses, but currently pulseaudio parses more properties than it uses (at least
the alias property is not being used for anything).

So, the necessary changes are to check that every non-optional interesting
property is received, and to remove the parsing of properties that aren't
actually used.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the QA Contact for the bug.</li>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>