<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Review the usage of pa_memblockq_push()"
href="https://bugs.freedesktop.org/show_bug.cgi?id=60405">60405</a>
</td>
</tr>
<tr>
<th>CC</th>
<td>lennart@poettering.net
</td>
</tr>
<tr>
<th>Assignee</th>
<td>pulseaudio-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Summary</th>
<td>Review the usage of pa_memblockq_push()
</td>
</tr>
<tr>
<th>QA Contact</th>
<td>pulseaudio-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Reporter</th>
<td>tanuk@iki.fi
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Other
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Component</th>
<td>misc
</td>
</tr>
<tr>
<th>Product</th>
<td>PulseAudio
</td>
</tr></table>
<p>
<div>
<pre>In many places the return value of pa_memblockq_push() and
pa_memblockq_push_align() isn't checked (a negative return value indicates that
the queue is full). In some places the function can't fail (an assertion could
be added for these), and in some places we're missing proper error handling in
case the queue gets full.
There is already a patch[1] that adds some assertions. I don't apply it now,
because it's old and might need updating for the current codebase, and it's
incomplete anyway (many FIXME items).
Another issue is that pa_memblock_push_align() is often used where
pa_memblockq_push() could be used.
[1] <a href="http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/13312">http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/13312</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>