<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - tunnel modules cannot figure out adress/auth automatically" href="https://bugs.freedesktop.org/show_bug.cgi?id=55280#c7">Comment # 7</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - tunnel modules cannot figure out adress/auth automatically" href="https://bugs.freedesktop.org/show_bug.cgi?id=55280">bug 55280</a> from <a class="email" href="mailto:tanuk@iki.fi" title="Tanu Kaskinen <tanuk@iki.fi>"> Tanu Kaskinen</a> <pre>The tunnel module should get rewritten so that it uses libpulse, and this bug should get resolved as a side effect. There is no 100% guarantee that the rewrite project will finish, so if you want this patch applied anyway, I'm not against that. Some review comments follow. In pa__init(), the server variable is never freed, even if it should be: #ifdef HAVE_X11 if ((server == NULL) && (xcb != NULL)) { char t[1024]; if (pa_x11_get_prop(xcb, 0, "PULSE_SERVER", t, sizeof(t))) server = pa_xstrdup(t); } #endif It doesn't seem like a good idea to connect to a local server by default. If the user loads module-tunnel-sink without any arguments, I think it should fail, because tunneling to a local daemon doesn't usually make sense. I think it would be better if connecting to a local server would require an explicit indication that the user really wants to do that.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>