<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - raop module does not work with shairport" href="https://bugs.freedesktop.org/show_bug.cgi?id=42804#c35">Comment # 35</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - raop module does not work with shairport" href="https://bugs.freedesktop.org/show_bug.cgi?id=42804">bug 42804</a> from <a class="email" href="mailto:crisp.fujita@nifty.com" title="Hajime Fujita <crisp.fujita@nifty.com>"> Hajime Fujita</a> <pre>Hi Matthias, Thank you so much for the testing and reporting. By looking at your patch for ALAC support, I found out that the real issue might not be in the ALAC encoding, but in the raw buffer handling. I wrote a one-line patch inspired by your patch. <a href="https://github.com/hfujita/pulseaudio-raop2/commit/3b35e02e473873f64e2a5967f4cc55e05ae9d00a">https://github.com/hfujita/pulseaudio-raop2/commit/3b35e02e473873f64e2a5967f4cc55e05ae9d00a</a> This fixes the "rough sound" issue in my VSX-43+Ryhthmbox, even without Apple's codec integration. I'm happy to hear any results from testing this patch. (However, the sound from Adobe Flash is still terrible. I suppose this is due to a different cause.) Regarding ALAC licensing, I actually had a similar concern. That's why I haven't made my ALAC integration branch public, while I already have it locally. Since I'm not a law expert in any sense, the following should not be taken seriously :) In the most optimistic way of thinking, header section in each ALAC source file states that the file is licensed under the Apache License, so I hope we can just believe it. However, still I'm not sure if it's okay to link Apache Licensed library into PulseAudio. The license file in the pulseaudio top directory says that the server side implementation of PA should be treated as GPL-licensed. So the question would be "can we link Apache Licensed library to GPL product"? One possible workaround would be to find another encoder implementation, such as in libav.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>