<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - bluetooth/module-bluetooth-policy.c:150: possible bad if test ?"
href="https://bugs.freedesktop.org/show_bug.cgi?id=72414">72414</a>
</td>
</tr>
<tr>
<th>CC</th>
<td>lennart@poettering.net
</td>
</tr>
<tr>
<th>Assignee</th>
<td>pulseaudio-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Summary</th>
<td>bluetooth/module-bluetooth-policy.c:150: possible bad if test ?
</td>
</tr>
<tr>
<th>QA Contact</th>
<td>pulseaudio-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Reporter</th>
<td>dcb314@hotmail.com
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Component</th>
<td>modules
</td>
</tr>
<tr>
<th>Product</th>
<td>PulseAudio
</td>
</tr></table>
<p>
<div>
<pre>I just ran static analyser "cppcheck" over the
source code of pulseaudio-4.0-266-gf81e3. It said
many things, including
[modules/bluetooth/module-bluetooth-policy.c:150] ->
[modules/bluetooth/module-bluetooth-policy.c:150]: (style) Same expression on
both sides of '>'.
Source code is
if (result == NULL ||
(profile->available == PA_AVAILABLE_YES && result->available ==
PA_AVAILABLE_UNKNOWN) ||
(profile->available == result->available && profile->priority >
profile->priority))
Suggest code rework.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>