<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:colin@mageia.org" title="Colin Guthrie <colin@mageia.org>"> <span class="fn">Colin Guthrie</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement systemd socket activation in pulseaudio"
href="https://bugs.freedesktop.org/show_bug.cgi?id=78701">bug 78701</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>colin@mageia.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement systemd socket activation in pulseaudio"
href="https://bugs.freedesktop.org/show_bug.cgi?id=78701#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement systemd socket activation in pulseaudio"
href="https://bugs.freedesktop.org/show_bug.cgi?id=78701">bug 78701</a>
from <span class="vcard"><a class="email" href="mailto:colin@mageia.org" title="Colin Guthrie <colin@mageia.org>"> <span class="fn">Colin Guthrie</span></a>
</span></b>
<pre>Ooops, I should have read this bug before hacking on the same things!
I posted a separate patch to the ML to do this too. Mine doesn't do the IP
activation yet however (I was lazy!), but as with this patch it's relatively
trivial to add.
I opted for not creating a new function to adopt the socket and just checked
when creating a new socket server if we happen to have a passed FD that matches
via the sd_is_socket_*() function and avoid the bind+listen step. That seems
cleaner to me that a separate adopt function, but perhaps that's just taste.
Some things slightly different in my patch:
1. I still set filename for unix sockets such that the address is properly
calculated and thus exported in e.g. module-x11-publish. I use a separate
variable inside the socket server to track whether it's been activated and
avoid the unlink when closing.
2. I added an install-data-hook to automatically ship a static symlink to start
the socket. This means that it users do not need to do any manual configuration</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>