<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Module restore restores volume and mute settings from wrong sink input" href="https://bugs.freedesktop.org/show_bug.cgi?id=93855#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Module restore restores volume and mute settings from wrong sink input" href="https://bugs.freedesktop.org/show_bug.cgi?id=93855">bug 93855</a> from <a class="email" href="mailto:leonard-rh-bugzilla@den.ottolander.nl" title="Leonard den Ottolander <leonard-rh-bugzilla@den.ottolander.nl>"> Leonard den Ottolander</a> <pre>I think you misunderstand what I say. To restore the stream a /unique/ identifier needs to be used. The currently used function function pa_proplist_get_stream_group() does not do this as it returns a non unique application name. Using the pid of the original stream is perfectly fine. The module is just looking for a unique string and the pid of the (old) stream is such a unique name. The string is not used to look for the process with that particular pid, it is just a way to ensure that the string that identifies the stream is unique. The patches in my first example actually fix the module restore stream, but as I explain in <a href="show_bug.cgi?id=93855#c2">comment #2</a> reusing the function pa_proplist_get_stream_group() is a bad idea as it interferes with module-filter-apply.c. This is why I split out the function pa_proplist_get_stream_id() in the attached patch.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>