[pulseaudio-commits] 3 commits - src/modules src/pulsecore

[Arun Raghavan]

 src/modules/alsa/alsa-util.c |    4 ++--
 src/pulsecore/cpu-arm.h      |    2 +-
 src/pulsecore/svolume_arm.c  |    2 +-
 src/pulsecore/svolume_mmx.c  |    2 +-
 src/pulsecore/svolume_orc.c  |    2 +-
 src/pulsecore/svolume_sse.c  |    2 +-
 6 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit d103f3a97a151682a1c4c1257e32d4affb4c162e
Author: Peter Meerwald <p.meerwald at bct-electronic.com>
Date:   Thu Jan 12 17:20:05 2012 +0100

    core: svolume tests should generate realistic random volume data
    
    assuming RAND_MAX is around 1<<31, rand() >> 1 generates large numbers as
    random volume data; these likely causes saturated sample values after
    applying the volume function -- not a good test

diff --git a/src/pulsecore/svolume_arm.c b/src/pulsecore/svolume_arm.c
index 455d746..f938e57 100644
--- a/src/pulsecore/svolume_arm.c
+++ b/src/pulsecore/svolume_arm.c
@@ -151,7 +151,7 @@ static void run_test(void) {
     memcpy(samples_orig, samples, sizeof(samples));
 
     for (i = 0; i < CHANNELS; i++)
-        volumes[i] = PA_CLAMP_VOLUME(rand() >> 1);
+        volumes[i] = PA_CLAMP_VOLUME(rand() >> 15);
     for (padding = 0; padding < PADDING; padding++, i++)
         volumes[i] = volumes[padding];
 
diff --git a/src/pulsecore/svolume_mmx.c b/src/pulsecore/svolume_mmx.c
index 43c1058..f9fc175 100644
--- a/src/pulsecore/svolume_mmx.c
+++ b/src/pulsecore/svolume_mmx.c
@@ -272,7 +272,7 @@ static void run_test(void) {
     memcpy(samples_orig, samples, sizeof(samples));
 
     for (i = 0; i < CHANNELS; i++)
-        volumes[i] = PA_CLAMP_VOLUME(rand() >> 1);
+        volumes[i] = PA_CLAMP_VOLUME(rand() >> 15);
         /* volumes[i] = 0x0000ffff; */
     for (padding = 0; padding < PADDING; padding++, i++)
         volumes[i] = volumes[padding];
diff --git a/src/pulsecore/svolume_orc.c b/src/pulsecore/svolume_orc.c
index 86f843e..b178bbf 100644
--- a/src/pulsecore/svolume_orc.c
+++ b/src/pulsecore/svolume_orc.c
@@ -75,7 +75,7 @@ static void run_test(void) {
     memcpy(samples_orig, samples, sizeof(samples));
 
     for (i = 0; i < CHANNELS; i++)
-        volumes[i] = PA_CLAMP_VOLUME(rand() >> 1);
+        volumes[i] = PA_CLAMP_VOLUME(rand() >> 15);
     for (padding = 0; padding < PADDING; padding++, i++)
         volumes[i] = volumes[padding];
 
diff --git a/src/pulsecore/svolume_sse.c b/src/pulsecore/svolume_sse.c
index 89414c6..fe08de4 100644
--- a/src/pulsecore/svolume_sse.c
+++ b/src/pulsecore/svolume_sse.c
@@ -282,7 +282,7 @@ static void run_test(void) {
     memcpy(samples_orig, samples, sizeof(samples));
 
     for (i = 0; i < CHANNELS; i++)
-        volumes[i] = PA_CLAMP_VOLUME(rand() >> 1);
+        volumes[i] = PA_CLAMP_VOLUME(rand() >> 15);
     for (padding = 0; padding < PADDING; padding++, i++)
         volumes[i] = volumes[padding];
 

commit ee3e93c84106c61c33d15476a8847619f358a372
Author: Peter Meerwald <p.meerwald at bct-electronic.com>
Date:   Thu Jan 12 17:20:04 2012 +0100

    core: whitespace typo

diff --git a/src/pulsecore/cpu-arm.h b/src/pulsecore/cpu-arm.h
index 0e0c3e4..f0f49ef 100644
--- a/src/pulsecore/cpu-arm.h
+++ b/src/pulsecore/cpu-arm.h
@@ -35,7 +35,7 @@ typedef enum pa_cpu_arm_flag {
     PA_CPU_ARM_VFPV3    = (1 << 5)
 } pa_cpu_arm_flag_t;
 
-pa_bool_t pa_cpu_init_arm (pa_cpu_arm_flag_t *flags);
+pa_bool_t pa_cpu_init_arm(pa_cpu_arm_flag_t *flags);
 
 /* some optimized functions */
 void pa_volume_func_init_arm(pa_cpu_arm_flag_t flags);

commit db8fa449e48cbaff053f335fdfa733400615c4b0
Author: Peter Meerwald <p.meerwald at bct-electronic.com>
Date:   Thu Jan 12 17:20:03 2012 +0100

    alsa: fix comment

diff --git a/src/modules/alsa/alsa-util.c b/src/modules/alsa/alsa-util.c
index c30a722..d961fbc 100644
--- a/src/modules/alsa/alsa-util.c
+++ b/src/modules/alsa/alsa-util.c
@@ -310,8 +310,8 @@ int pa_alsa_set_hw_params(
             pa_log_debug("Maximum hw buffer size is %lu ms", (long unsigned) (max_frames * PA_MSEC_PER_SEC / _ss.rate));
 
         /* Some ALSA drivers really don't like if we set the buffer
-         * size first and the number of periods second. (which would
-         * make a lot more sense to me) So, try a few combinations
+         * size first and the number of periods second (which would
+         * make a lot more sense to me). So, try a few combinations
          * before we give up. */
 
         if (_buffer_size > 0 && _period_size > 0) {