[pulseaudio-commits] Branch 'next' - src/modules

David Henningsson diwic at kemper.freedesktop.org
Tue May 14 02:08:07 PDT 2013


 src/modules/alsa/module-alsa-card.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 21b57d9978627df2b37937a04dd445e80e834663
Author: David Henningsson <david.henningsson at canonical.com>
Date:   Tue May 14 11:01:13 2013 +0200

    alsa: Fix crash when profile_set == NULL
    
    Better check if the pointer is NULL before dereferencing it, instead of
    after!
    
    BugLink: https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/1159853
    Signed-off-by: David Henningsson <david.henningsson at canonical.com>

diff --git a/src/modules/alsa/module-alsa-card.c b/src/modules/alsa/module-alsa-card.c
index b37eabc..fe05e3d 100644
--- a/src/modules/alsa/module-alsa-card.c
+++ b/src/modules/alsa/module-alsa-card.c
@@ -689,11 +689,11 @@ int pa__init(pa_module *m) {
         pa_xfree(fn);
     }
 
-    u->profile_set->ignore_dB = ignore_dB;
-
     if (!u->profile_set)
         goto fail;
 
+    u->profile_set->ignore_dB = ignore_dB;
+
     pa_alsa_profile_set_probe(u->profile_set, u->device_id, &m->core->default_sample_spec, m->core->default_n_fragments, m->core->default_fragment_size_msec);
     pa_alsa_profile_set_dump(u->profile_set);
 



More information about the pulseaudio-commits mailing list