[pulseaudio-commits] src/pulsecore

[Tanu Kaskinen]

 src/pulsecore/sink.h   |    6 ++++++
 src/pulsecore/source.h |    6 ++++++
 2 files changed, 12 insertions(+)

New commits:
commit 5c860fe06d00fec459730818bb2e28e615deea8b
Author: Tanu Kaskinen <tanu.kaskinen at linux.intel.com>
Date:   Sun Nov 17 21:22:20 2013 +0200

    sink, source: Add a TODO comment about removing get_formats()

diff --git a/src/pulsecore/sink.h b/src/pulsecore/sink.h
index e12faba..ded80c0 100644
--- a/src/pulsecore/sink.h
+++ b/src/pulsecore/sink.h
@@ -461,7 +461,13 @@ pa_queue *pa_sink_move_all_start(pa_sink *s, pa_queue *q);
 void pa_sink_move_all_finish(pa_sink *s, pa_queue *q, bool save);
 void pa_sink_move_all_fail(pa_queue *q);
 
+/* Returns a copy of the sink formats. TODO: Get rid of this function (or at
+ * least get rid of the copying). There's no good reason to copy the formats
+ * every time someone wants to know what formats the sink supports. The formats
+ * idxset could be stored directly in the pa_sink struct.
+ * https://bugs.freedesktop.org/show_bug.cgi?id=71924 */
 pa_idxset* pa_sink_get_formats(pa_sink *s);
+
 bool pa_sink_set_formats(pa_sink *s, pa_idxset *formats);
 bool pa_sink_check_format(pa_sink *s, pa_format_info *f);
 pa_idxset* pa_sink_check_formats(pa_sink *s, pa_idxset *in_formats);
diff --git a/src/pulsecore/source.h b/src/pulsecore/source.h
index b20d4c0..e7e9da9 100644
--- a/src/pulsecore/source.h
+++ b/src/pulsecore/source.h
@@ -394,7 +394,13 @@ pa_queue *pa_source_move_all_start(pa_source *s, pa_queue *q);
 void pa_source_move_all_finish(pa_source *s, pa_queue *q, bool save);
 void pa_source_move_all_fail(pa_queue *q);
 
+/* Returns a copy of the source formats. TODO: Get rid of this function (or at
+ * least get rid of the copying). There's no good reason to copy the formats
+ * every time someone wants to know what formats the source supports. The
+ * formats idxset could be stored directly in the pa_source struct.
+ * https://bugs.freedesktop.org/show_bug.cgi?id=71924 */
 pa_idxset* pa_source_get_formats(pa_source *s);
+
 bool pa_source_check_format(pa_source *s, pa_format_info *f);
 pa_idxset* pa_source_check_formats(pa_source *s, pa_idxset *in_formats);