[pulseaudio-discuss] NetBSD patches
lennart at poettering.net
Thu Jan 22 14:42:21 PST 2009
On Thu, 22.01.09 17:08, Jared D. McNeill (jmcneill at NetBSD.org) wrote:
> >> > patch-ac (The #if 0 is a bit too radical for my taste ;-). For n_cpus
> >> > there is now a proper function pa_ncpus() elsewhere)
> >> The first revision of that section of the patch patch was #ifdef
> >> __linux__, then it was later changed to #if 0 by another pkgsrc
> >> developer with the following message:
> >> ``The rtstutter test is afunctional for all operating systems but one. Make it
> >> go one operating system further.
> > Uh? I don't follow. What's the point of breaking rtstutter on Linux
> > like this?
> As I said, I didn't write the patch, nor is that comment from me.
> How about a --disable-tests flag to configure so we can skip building
> it altogether?
Such a patch went into git two days ago, supplied by the Gentoo folks.
> > On Linux /dev/sound is unknown and /dev/audio is some weird
> > not-really-supported, not-really-standardized, mostly obsolete
> > interface. If emulating these is useful on NetBSD an #ifdef check is
> > probably appropriate here, too.
> > (Also given that this check becomes quite complex now and it is done
> > multiple times it should be moved to an explicit function)
> Since they are the only entry points to the audio subsystem on NetBSD,
> it is necessary.
> Ideally, you would want something like:
> #if defined(__NetBSD__)
> #include <paths.h>
> [check path against _PATH_SOUND and _PATH_AUDIO]
Sounds good. Happy to merge a patch like this!
> >> Not quite sure what that is, but I will find out. Please keep in mind
> >> that the patches maintained in pkgsrc are against release versions of
> >> software only.
> > You NetBSD folks are not infected by the git virus yet, are you? Still
> > stuck with CVS?
> Stuck in the most literal sense. Either the replacements don't scale
> to our massive repository or don't have the features we need.
This is certainly not the place to have a discussion about VCSes, but
somehow I doubt that git would have much of scalability issue here.
Lennart Poettering Red Hat, Inc.
lennart [at] poettering [dot] net ICQ# 11060553
http://0pointer.net/lennart/ GnuPG 0x1A015CC4
More information about the pulseaudio-discuss