[pulseaudio-discuss] stream_started_callback userdata bug

[Lennart Poettering]

On Tue, 09.09.08 20:28, Arthur Taylor (theycallhimart at gmail.com) wrote:

> Hello
> 
> I came across a bug where the userdata parameter of the
> stream_started_callback was always NULL in some cases. I couldn't seem
> to make a ticket, so here's the one line patch:

You need to create a user in Trac to create a ticket (i had to enable
that to fight spammers, sorry). But tbh I even prefer patches by email
if they are properly formatted git patches like yours is now. 

Thanks for the patch. Applied.

Packagers should probably steal this patch and the other one I just
commited into their packages!

> 
> diff --git a/src/pulse/stream.c b/src/pulse/stream.c
> index d0c7d67..a832b44 100644
> --- a/src/pulse/stream.c
> +++ b/src/pulse/stream.c
> @@ -557,7 +557,7 @@ void pa_command_stream_started(pa_pdispatch *pd, uint32_t command, uint32_t tag,
>      request_auto_timing_update(s, TRUE);
>  
>      if (s->started_callback)
> -        s->started_callback(s, s->suspended_userdata);
> +        s->started_callback(s, s->started_userdata);
>  
>  finish:
>      pa_context_unref(c);


Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net         ICQ# 11060553
http://0pointer.net/lennart/           GnuPG 0x1A015CC4