[pulseaudio-discuss] [PATCH] attach X11 properties to Screen, not Display

[Lennart Poettering]

On Mon, 26.10.09 23:45, Leszek Koltunski (leszek at koltunski.pl) wrote:

> The patch below attaches X11 properties to a Screen, not a Display. Using
> it, I am able to do the following:

Uh. As mentioned earlier I'd prefer if when reading those props we
would fallback to screen 0 if the default screen has no data attached
and the default screen isn't 0 anyway.

That would have two advantages: firstly, we keep better compat with
the current logic. Secondly, this would allow us to cater for both the
folks who want to attach the audio server contact data to screens and those
who want to attach it to displays.

Otherwise the patch looks good to me.

> However when I try to play something from :0.1, all I can hear is silence. I
> notice that for some reason PULSE_SESSION is missing from :0.1's root
> window. I add it:
> 
> leszek# xprop -root -display ":0.1" -f PULSE_SESSION_ID 8s -set
> PULSE_SESSION_ID
> 571eae318b6377f95367e6524abdec09-1256566213.375419-376893987
> 
> ..and everything works!

That prop is added by module-publish-x11 and is simply used to make
sure that the module on unload does not kill the data someone else set.


Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net
http://0pointer.net/lennart/           GnuPG 0x1A015CC4