[pulseaudio-discuss] [PATCH] bluetooth-device: fix rounding errors caused by few bt volume steps

Colin Guthrie gmane at colin.guthr.ie
Tue Apr 5 03:26:11 PDT 2011


'Twas brillig, and Juho Hämäläinen at 04/04/11 13:24 did gyre and gimble:
> 
> When volume changes in bluetooth device PulseAudio volume is rounded
> one too low, so if bluetooth headset changes volume and that volume
> is immediately set again for bluetooth device, bluetooth step drifts
> lower all the time. Volume is incremented by one in the conversion so
> that we get right bluetooth step when re-applying volume.
> 
> Signed-off-by: Juho Hämäläinen <ext-juho.hamalainen at nokia.com>
> ---
>  src/modules/bluetooth/module-bluetooth-device.c |   48
> +++++++++++++++++-----
>  1 files changed, 37 insertions(+), 11 deletions(-)


I don't know the volume stuff very well, but I'll take your word for it!

Applied with a couple minor formatting tweaks (spacing and brackets)

Cheers

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]




More information about the pulseaudio-discuss mailing list