[pulseaudio-discuss] [PATCH] svolume: Make log messages more precise.

Tanu Kaskinen tanuk at iki.fi
Sat Aug 13 04:48:34 PDT 2011


I was looking at a log, and noticed the following lines:

I  [pulseaudio] svolume_mmx.c: Initialising MMX optimized functions.
I  [pulseaudio] remap_mmx.c: Initialising MMX optimized remappers.
I  [pulseaudio] svolume_sse.c: Initialising SSE2 optimized functions.
I  [pulseaudio] remap_sse.c: Initialising SSE2 optimized remappers.
I  [pulseaudio] sconv_sse.c: Initialising SSE2 optimized conversions.

It seemed odd that some messages were somewhat precise in
what functionality was initialized, while the svolume
messages told me that they had initialized just "functions".
So I made the svolume log messages more precise to match the
sconv and remap messages.
---
 src/pulsecore/svolume_arm.c |    2 +-
 src/pulsecore/svolume_mmx.c |    2 +-
 src/pulsecore/svolume_orc.c |    2 +-
 src/pulsecore/svolume_sse.c |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/pulsecore/svolume_arm.c b/src/pulsecore/svolume_arm.c
index b779733..455d746 100644
--- a/src/pulsecore/svolume_arm.c
+++ b/src/pulsecore/svolume_arm.c
@@ -207,7 +207,7 @@ static void run_test(void) {
 
 void pa_volume_func_init_arm(pa_cpu_arm_flag_t flags) {
 #if defined (__arm__) && defined (HAVE_ARMV6)
-    pa_log_info("Initialising ARM optimized functions.");
+    pa_log_info("Initialising ARM optimized volume functions.");
 
 #ifdef RUN_TEST
     run_test();
diff --git a/src/pulsecore/svolume_mmx.c b/src/pulsecore/svolume_mmx.c
index 6401081..a8a233d 100644
--- a/src/pulsecore/svolume_mmx.c
+++ b/src/pulsecore/svolume_mmx.c
@@ -335,7 +335,7 @@ void pa_volume_func_init_mmx(pa_cpu_x86_flag_t flags) {
 #endif
 
     if ((flags & PA_CPU_X86_MMX) && (flags & PA_CPU_X86_CMOV)) {
-        pa_log_info("Initialising MMX optimized functions.");
+        pa_log_info("Initialising MMX optimized volume functions.");
 
         pa_set_volume_func(PA_SAMPLE_S16NE, (pa_do_volume_func_t) pa_volume_s16ne_mmx);
         pa_set_volume_func(PA_SAMPLE_S16RE, (pa_do_volume_func_t) pa_volume_s16re_mmx);
diff --git a/src/pulsecore/svolume_orc.c b/src/pulsecore/svolume_orc.c
index 8e1e46c..86f843e 100644
--- a/src/pulsecore/svolume_orc.c
+++ b/src/pulsecore/svolume_orc.c
@@ -127,7 +127,7 @@ static void run_test(void) {
 #endif
 
 void pa_volume_func_init_orc(void) {
-    pa_log_info("Initialising ORC optimized functions.");
+    pa_log_info("Initialising ORC optimized volume functions.");
 
 #ifdef RUN_TEST
     run_test();
diff --git a/src/pulsecore/svolume_sse.c b/src/pulsecore/svolume_sse.c
index f713761..6a73270 100644
--- a/src/pulsecore/svolume_sse.c
+++ b/src/pulsecore/svolume_sse.c
@@ -342,7 +342,7 @@ void pa_volume_func_init_sse(pa_cpu_x86_flag_t flags) {
 #endif
 
     if (flags & PA_CPU_X86_SSE2) {
-        pa_log_info("Initialising SSE2 optimized functions.");
+        pa_log_info("Initialising SSE2 optimized volume functions.");
 
         pa_set_volume_func(PA_SAMPLE_S16NE, (pa_do_volume_func_t) pa_volume_s16ne_sse2);
         pa_set_volume_func(PA_SAMPLE_S16RE, (pa_do_volume_func_t) pa_volume_s16re_sse2);
-- 
1.7.5.4



More information about the pulseaudio-discuss mailing list