[pulseaudio-discuss] [PATCH] Get rid of some warnings
gmane at colin.guthr.ie
Sun Mar 20 06:12:18 PDT 2011
'Twas brillig, and Maarten Bosmans at 19/03/11 15:26 did gyre and gimble:
> Mostly warnings about unused stuff.
> Furthermore, the first hunk is a fix for the change in 177948a6.
> Finally, comment in AEC_dtd was translated and the code simplified slightly.
> CC module_echo_cancel_la-adrian-aec.lo
> modules/echo-cancel/adrian-aec.h:360:15: warning: ‘AEC_getambient’ defined but not used [-Wunused-function]
> modules/echo-cancel/adrian-aec.h:368:14: warning: ‘AEC_setgain’ defined but not used [-Wunused-function]
> modules/echo-cancel/adrian-aec.h:374:14: warning: ‘AEC_setaes’ defined but not used [-Wunused-function]
> modules/echo-cancel/adrian-aec.h:377:16: warning: ‘AEC_max_dotp_xf_xf’ declared ‘static’ but never defined [-Wunused-function]
Is the Adrian code ours or is it external in some capacity. Arun, if
it's external and we will update it periodically, can you do the
necessary to push where it needs to go? (Obviously the PA_GCC_UNUSED
cannot be pushed anywhere).
> CC module_echo_cancel_la-module-echo-cancel.lo
> modules/echo-cancel/module-echo-cancel.c: In function ‘time_callback’:
> modules/echo-cancel/module-echo-cancel.c:266:12: warning: variable ‘fs’ set but not used [-Wunused-but-set-variable]
I made a couple tweaks here to use /* */ rather than // as is Lennart's
general desire (doesn't bother me personally but meh!)
So merged now.
Tribalogic Limited [http://www.tribalogic.net/]
Mageia Contributor [http://www.mageia.org/]
PulseAudio Hacker [http://www.pulseaudio.org/]
Trac Hacker [http://trac.edgewall.org/]
More information about the pulseaudio-discuss