[pulseaudio-discuss] [PATCH] alsa-mixer: When setting hw volume, round always up with playback and always down with capture.

Tanu Kaskinen tanuk at iki.fi
Thu May 19 11:30:27 PDT 2011


On Tue, 2011-05-17 at 19:40 +0100, Colin Guthrie wrote:
> Just to report that a modified version of that patch does indeed fix the
> problem for me.
> 
> What do you think overall? Should we try and hunt down the problems with
> the conversion or should this patch be included?

I think it would make sense to save the intermediate volume as integer
millibels - that way there couldn't be any rounding errors, because no
rounding would happen.

The patch works, though, so I'm not against applying it. That would be
the easier way forward - from a quick glance at the code it seems that
changing the volume format will involve more than just changing a
variable type.

-- 
Tanu




More information about the pulseaudio-discuss mailing list