[pulseaudio-discuss] [PATCH] Use fastpath assert in trivial resampler

Maarten Bosmans mkbosmans at gmail.com
Tue Oct 11 23:26:56 PDT 2011


Is there some way we could define FASTPATH by default, (so that the
pa_assert_fp calls actually get turned into NOPs), while preserving
full asserts when configured with ./bootstrap.sh?

Maarten

2011/10/12 Maarten Bosmans <mkbosmans at gmail.com>:
> When the assert is disabled, the trivial resampler gets a 35% performance boost.
> ---
>  src/pulsecore/resampler.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/pulsecore/resampler.c b/src/pulsecore/resampler.c
> index d4a7204..c3b6df1 100644
> --- a/src/pulsecore/resampler.c
> +++ b/src/pulsecore/resampler.c
> @@ -1391,7 +1391,7 @@ static void trivial_resample(pa_resampler *r, const pa_memchunk *input, unsigned
>         if (j >= in_n_frames)
>             break;
>
> -        pa_assert(o_index * fz < pa_memblock_get_length(output->memblock));
> +        pa_assert_fp(o_index * fz < pa_memblock_get_length(output->memblock));
>
>         memcpy((uint8_t*) dst + fz * o_index,
>                    (uint8_t*) src + fz * j, (int) fz);
> --
> 1.7.4.1
>
>


More information about the pulseaudio-discuss mailing list