[pulseaudio-discuss] [PATCH] alsa-card: Handle the "profile" modarg.

Tanu Kaskinen tanuk at iki.fi
Wed Oct 19 23:52:56 PDT 2011


On Thu, 2011-10-20 at 09:33 +0530, Arun Raghavan wrote:
> On Mon, 2011-10-03 at 18:11 +0300, Tanu Kaskinen wrote:
> > ---
> 
> Pulled to my tree with a fix to the commit message since I'd like to
> (somewhat) standardise the namespaces for commit messages.

Do you mean that you'd like to only ever use "alsa" as the commit prefix
for anything alsa related? I don't really like that - I think the
precision for example with "alsa-card" is useful. The information could
be added to the main part of the commit message, for example "alsa:
Handle the profile modarg in module-alsa-card", but I don't see any real
improvement in that. And in this case the message is reasonably short,
but often you have to work harder to make the headline reasonably brief,
and the prefix usually can express things more concisely than the
"natural language" of the main headline sentence. What are the benefits
of limiting the number of available prefixes?

FWIW, when you changed "main" to "daemon" in a recent patch, that was
totally fine, because there was no significant loss in precision, and
"daemon" has been the standard so far.

-- 
Tanu



More information about the pulseaudio-discuss mailing list