[pulseaudio-discuss] [PATCH v3] role-ducking: Apply a ducking effect based on streams roles

[Flávio Ceolin]

Hi Tanu,

On Fri, Dec 14, 2012 at 5:44 AM, Tanu Kaskinen <tanuk at iki.fi> wrote:
> On Thu, 2012-12-13 at 17:00 -0200, Flavio Ceolin wrote:
>> This module works pretty similar to the module-role-cork.
>> It should be used as an alternative to that module. Basically
>> it decreases the volume of the streams specified in ducking_roles
>> in the presence of at least one stream specified in trigger_roles.
>> Also, it's possible to choice the volume that will be used in the
>> ducking streams and if it should operates in all devices or not.
>>
>> For basic reference: http://en.wikipedia.org/wiki/Ducking
>> ---
>>  src/Makefile.am                   |  10 +-
>>  src/modules/module-role-ducking.c | 326 ++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 335 insertions(+), 1 deletion(-)
>>  create mode 100644 src/modules/module-role-ducking.c
>
> Thanks, applied to the "next" branch with some small changes: replaced
> "TRUE" and "FALSE" with "true" and "false", adjusted the "volume" module
> argument documentation and changed the default volume from full volume
> to -20dB. Defaulting to full volume doesn't make sense, because then the
> module does effectively nothing.
>

Yep, the default volume does nothing, i was thinking that if the user
does not set the volume the module should do nothing. But i prefer set
the default value to -20dB as well.

> --
> Tanu
>

Many thanks for reviewing and applying the patch.

Regards,
Flavio Ceolin