[pulseaudio-discuss] [PATCH 4/4] echo-cancel: Fix null implementation to setup one channel

Tanu Kaskinen tanuk at iki.fi
Sat Dec 15 00:54:55 PST 2012


On Tue, 2012-12-04 at 14:55 +0100, Peter Meerwald wrote:
> From: Stefan Huber <s.huber at bct-electronic.com>
> 
> memcpy() of the null implementation's run() copied data for only one
> channel. Set the number of channels to 1 in init() in order to guarantee
> this.
> 
> Signed-off-by: Stefan Huber <s.huber at bct-electronic.com>
> Acked-by: Peter Meerwald <p.meerwald at bct-electronic.com>
> ---
>  src/modules/echo-cancel/null.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/modules/echo-cancel/null.c b/src/modules/echo-cancel/null.c
> index 5f8ced2..6333848 100644
> --- a/src/modules/echo-cancel/null.c
> +++ b/src/modules/echo-cancel/null.c
> @@ -32,6 +32,8 @@ pa_bool_t pa_null_ec_init(pa_core *c, pa_echo_canceller *ec,
>      *nframes = 256;
>  
>      source_ss->format = PA_SAMPLE_S16NE;
> +    source_ss->channels = 1;
> +
>      *sink_ss = *source_ss;
>      *sink_map = *source_map;

Thanks, applied.

-- 
Tanu



More information about the pulseaudio-discuss mailing list