[pulseaudio-discuss] [PATCH] add module-virtual-surround-sink
arun.raghavan at collabora.co.uk
Thu Mar 8 01:26:24 PST 2012
On Thu, 2012-03-08 at 09:36 +0200, Tanu Kaskinen wrote:
> On Wed, 2012-03-07 at 14:53 +0100, Niels Ole Salscheider wrote:
> > We either have to keep the mapping (at least for the right ear) or store two
> > float arrays, one for the left and one for the right ear.
> > I do not have a strong preference either way. But if we decide to keep the
> > mapping for the right ear we can as well keep the one for the left ear and
> > leave the channel map configurable. I neither have a use case for this, though.
> > What approach do you prefer?
> Let's just keep the code as is. I don't have any further complaints, so
> expect the patch to be applied to git master soon :) I think we have
> some kind of a feature freeze at the moment - does anyone object adding
> this new module to 2.0?
> Thanks a lot for your contribution; I hope that it wasn't a too
> frustrating experience, and that we'll see more stuff coming from you in
> the future :)
Since it's reviewed and not on by default, go ahead and push it. I'm
still way way behind on getting the pending reviews done. :(
More information about the pulseaudio-discuss