[pulseaudio-discuss] module-pipe-source,sink

[Arun Raghavan]

On Tue, 2012-05-29 at 09:05 +0530, Arun Raghavan wrote:
> On Thu, 2012-05-24 at 17:46 +0200, Peter Meerwald wrote:
> > Hello,
> > 
> > I have a couple of issues with module-pipe:
> > 
> > 1. module-pipe-source and module-pipe-sink do not check the return value 
> > ofmkfifo(), hence PulseAudio happily opens the same pipe several times
> > 
> > I think PulseAudio should check if mkfifo() fails to create the FIFO file 
> > and abort -- see suggested patch in next mail
> 
> Pulled both your patches.
> 
> > 2. documentation at 
> > http://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Modules#module-pipe-sink
> > incorrectly states that the FIFO of module-pipe-sink defaults to 
> > /tmp/music.output, in fact it defaults to /tmp/pulse-xxxxxxxxx/fifo_output
> > 
> > 3. module-pipe-source defaults to /tmp/music.input (as per documentation), 
> > but this is inconsistent with module-pipe-sink
> 
> I think a standard location makes more sense than something created with
> mkstemp(). Don't know if changing this will break something for existing
> users, though.

Hit send to quickly -- I'm fine with making the paths saner -- maybe use
XDG_RUNTIME_DIR for it and drop the "music" from the file name while
we're at it. Anybody have objections to this?

-- Arun