[pulseaudio-discuss] [PATCH] sample: Apply SPARC-specific condition on SPARC only

[Arun Raghavan]

On Tue, 2013-07-30 at 14:29 +0200, Peter Meerwald wrote:
> 
> > Improves correctness, unbreaks software volume in recent Android.
> > ---
> >  src/pulse/sample.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/pulse/sample.h b/src/pulse/sample.h
> > index 9eb4df0..34087e0 100644
> > --- a/src/pulse/sample.h
> > +++ b/src/pulse/sample.h
> > @@ -120,7 +120,7 @@ PA_C_DECL_BEGIN
> >  #endif
> >  
> >  /* On Sparc, WORDS_BIGENDIAN needs to be set if _BIG_ENDIAN is defined. */
> > -#ifdef _BIG_ENDIAN
> > +#if defined(__sparc__) && defined(_BIG_ENDIAN)
> >  #define WORDS_BIGENDIAN
> >  #endif
> 
> this potentially breaks other big endian platforms? PPC/MIPS maybe?

Pretty sure it won't. That bit of code was added in 4.0 specifically to
deal with Sparc.

> are there big-endian Android devices? who sets this? why?

There aren't, but they seem to be defining _BIG_ENDIAN in their headers
for some reason.

-- Arun