[pulseaudio-discuss] [PATCH 1/2] module-switch-on-port-available: Don't switch profiles on uninitialized cards

[David Henningsson]

Now pushed (almost trivial, no review for one week and patch has
successful testing).

On 03/28/2014 12:06 PM, David Henningsson wrote:
> This could cause the HDMI port to become the default on some systems
> where analog output was available.
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/1256511
> BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=73375
> Signed-off-by: David Henningsson <david.henningsson at canonical.com>
> ---
>  src/modules/module-switch-on-port-available.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/modules/module-switch-on-port-available.c b/src/modules/module-switch-on-port-available.c
> index 2c7ad17..c560306 100644
> --- a/src/modules/module-switch-on-port-available.c
> +++ b/src/modules/module-switch-on-port-available.c
> @@ -173,6 +173,11 @@ static pa_hook_result_t port_available_hook_callback(pa_core *c, pa_device_port
>          return PA_HOOK_OK;
>      }
>  
> +    if (pa_idxset_size(card->sinks) == 0 && pa_idxset_size(card->sources) == 0)
> +        /* This card is not initialized yet. We'll handle it in
> +           sink_new / source_new callbacks later. */
> +        return PA_HOOK_OK;
> +
>      find_sink_and_source(card, port, &sink, &source);
>  
>      is_active_profile = card->active_profile == pa_hashmap_get(port->profiles, card->active_profile->name);
> 



-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic