[pulseaudio-discuss] [PATCH v2] sink/source: Initialize port before fixate hook (fixes volume/mute not saved)

[David Henningsson]

On 03/28/2014 11:11 AM, David Henningsson wrote:
> On 03/25/2014 09:15 AM, Tanu Kaskinen wrote:
>> On Tue, 2014-03-25 at 08:05 +0100, David Henningsson wrote:
>>> In case a port has not yet been saved, which is e g often the case
>>> if a sink/source has only one port, reading volume/mute will be done
>>> without port, whereas writing volume/mute will be done with port.
>>>
>>> Work around this by setting a default port before the fixate hook,
>>> so module-device-restore can read volume/mute for the correct port.
>>>
>>> BugLink: https://bugs.launchpad.net/bugs/1289515
>>> Signed-off-by: David Henningsson <david.henningsson at canonical.com>
>>> ---
>>>  src/pulsecore/device-port.c |   27 +++++++++++++++++++++++++++
>>>  src/pulsecore/device-port.h |    2 ++
>>>  src/pulsecore/sink.c        |   27 ++++++++++-----------------
>>>  src/pulsecore/source.c      |   28 ++++++++++------------------
>>>  4 files changed, 49 insertions(+), 35 deletions(-)
>>
>> Looks good to me.
>>
> 
> Thanks, pushed. Okay to push the attached one too?

Attached patch pushed now (trivial).



-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic